From: George Barrett <bob@bob131.so>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/3] Guile: add {r,}value-reference-value
Date: Thu, 29 Apr 2021 03:11:29 +1000 [thread overview]
Message-ID: <ouvdnsudrwqw35qvv4fv4ptudwxm5v52p_1n2pxdsjh7fnde73sh@mail.bob131.so> (raw)
In-Reply-To: <20210428165945.GB2364578@embecosm.com>
On Wed, Apr 28, 2021 at 05:59:45PM +0100, Andrew Burgess wrote:
> Thank you for doing this work. I'm sorry to be a real pain, but could
> you rename the second new function to value-rvalue-reference-value
> please, I think this would be inline with the existing naming
> convention; the first 'value-' indicates that the function applies to
> something of value type, and the rest of the name
> 'rvalue-reference-value' indicates what you're going to get.
No problem, thank you for your patience with me. I have no objection to the
name change (in fact, I'm not sure why I thought the name I chose was an
appropriate one :P) so I'll roll a v4 in a moment.
> If you just make the rename as suggested, then this patch is approved.
>
> Thanks,
> Andrew
Thanks
next prev parent reply other threads:[~2021-04-28 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 16:27 [PATCH v3 0/3] Guile: add value-{reference,const}-value George Barrett
2021-04-28 16:27 ` [PATCH v3 1/3] Guile: improved rvalue reference support George Barrett
2021-04-28 16:38 ` Eli Zaretskii
2021-04-28 16:54 ` Andrew Burgess
2021-04-28 16:27 ` [PATCH v3 2/3] Guile: add {r,}value-reference-value George Barrett
2021-04-28 16:40 ` Eli Zaretskii
2021-04-28 16:59 ` Andrew Burgess
2021-04-28 17:11 ` George Barrett [this message]
2021-04-28 16:27 ` [PATCH v3 3/3] Guile: add value-const-value George Barrett
2021-04-28 16:39 ` Eli Zaretskii
2021-04-28 17:00 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ouvdnsudrwqw35qvv4fv4ptudwxm5v52p_1n2pxdsjh7fnde73sh@mail.bob131.so \
--to=bob@bob131.so \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).