From: Cheng Renquan <crquan@gmail.com>
To: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>,
Joel Brobecker <brobecker@adacore.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
Date: Sat, 10 Apr 2010 21:23:00 -0000 [thread overview]
Message-ID: <s2n91b13c311004101422u87ab7e58k38d43de1feb96b5@mail.gmail.com> (raw)
In-Reply-To: <1270933267-14720-1-git-send-email-crquan@gmail.com>
On Sun, Apr 11, 2010 at 5:01 AM, Cheng <crquan@gmail.com> wrote:
> Index: gdb/cli/cli-cmds.c
[...]
> @@ -1119,8 +1120,16 @@ disassemble_command (char *arg, int from
> else
> {
> /* Two arguments. */
> + int incl_flag = 0;
> low = pc;
> + if (arg[0] == '+')
> + {
> + ++arg;
> + incl_flag = 1;
> + }
> high = parse_and_eval_address (arg);
> + if (incl_flag)
> + high += low;
This should satisfy GNU Coding Standards well,
On Fri, Apr 9, 2010 at 6:27 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> OK, I really know little about texinfo writing; Thanks,
>
> That's fine, I'm here to help ;-)
>
> Thanks for working on this.
I think there to add one disassemble example in the info file may be
better, but haven't figured out how to preview such a texinfo file,
the make process seems not touch it or use it to generate another
file?
suseuser@linux-orm5:~/src/gdb-trunk/src> info -f gdb/doc/gdb.texinfo
info: Cannot find node `Top'.
On Sat, Apr 10, 2010 at 2:14 AM, Tom Tromey <tromey@redhat.com> wrote:
>>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>>> add new support for disassemble by "start,+length" format;
>
> Do you have a copyright assignment in place?
> If not, let me know and I can get you started.
Not yet, you may mean a signed agreement to GNU FSF? I was formerly
asked to sign one when posting a patch to GNU wget last year, but
still don't get further messages there, I wonder if softcopy of
signment is accepted? please help get me restarted since this gdb
patch, thanks,
--
Cheng Renquan (程任全), from Singapore
next prev parent reply other threads:[~2010-04-10 21:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 21:01 crquan
2010-04-10 21:16 ` Eli Zaretskii
2010-04-10 21:23 ` Cheng Renquan [this message]
2010-04-13 23:29 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 4:11 crquan
2010-04-09 8:22 ` Eli Zaretskii
2010-04-09 9:35 ` Cheng Renquan
2010-04-09 10:29 ` Eli Zaretskii
2010-04-09 18:14 ` Tom Tromey
2010-04-08 15:09 crquan
2010-04-09 2:16 ` Hui Zhu
2010-04-15 7:44 ` crquan
2010-04-15 17:08 ` Eli Zaretskii
2010-04-15 17:14 ` Nathan Froyd
2010-04-15 17:38 ` Eli Zaretskii
2010-04-16 1:36 ` crquan
2010-04-20 15:43 ` Tom Tromey
2010-04-20 18:43 ` crquan
2010-04-30 14:21 ` Hui Zhu
2010-07-09 2:53 ` crquan
2010-07-09 8:23 ` Eli Zaretskii
2010-07-09 11:32 ` crquan
2010-07-11 11:53 ` Hui Zhu
2010-07-11 17:28 ` Cheng Renquan
2010-07-27 16:04 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s2n91b13c311004101422u87ab7e58k38d43de1feb96b5@mail.gmail.com \
--to=crquan@gmail.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).