From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122610 invoked by alias); 14 Nov 2016 19:14:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122591 invoked by uid 89); 14 Nov 2016 19:14:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_40,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:!Symantec, H*RU:!Symantec, H*RU:Unknown_Domain, Antoine X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Nov 2016 19:14:42 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by (Symantec Mail Security) with SMTP id DF.EC.02551.F1D0A285; Mon, 14 Nov 2016 20:14:39 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 Nov 2016 20:10:45 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.2; Mon, 14 Nov 2016 19:10:42 +0000 References: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Pedro Alves , Yao Qi CC: Subject: Re: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s In-Reply-To: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> Date: Mon, 14 Nov 2016 19:14:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY1PR13CA0074.namprd13.prod.outlook.com (10.163.230.170) To HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;2:8qHF4o0CSBKNw45zANn53yUIcgCYMRNS0OXIETreGIder/H4hhqHKqnNqNs6kG96cYrawFflsJbHUyXJ3Ba0wnGWkyaN49jEyB5RfdhcbUwBcRXZe7BLofSauZ9/3nW9Oe7VlnQV3b0awUVyUXXkXYr1wXbxiKMCN4zWNQfmm6s=;3:Sfq/tlQWcwqSRGhqtF668RDcFNSHcnuGmWvs2tIzHTboxQ/eYOFGwVKB0oNjnAFriYHyL9ldpO6KOmYQEHZr/XM5KP2ZI+1KMPK8++elpeXp93GmGpQzdWLmVngayKQWs+TIp3EIdgeGuwEpvtaY6XFqbmj51FQJ76rwzLmvAtQ=;25:QwJCrImAlNzazIJb2OjUElL6RwfWWWVRRHmhE8Akf1bqFi0M9OybKNCgtKXIW24ASQdaGQ1kBRUeSWyTrUv0lZ90yk1amQvh8tf86I4FlTtKISnpKT9p0lcCOl6dMkAcFtoJSNWfeEYZLnsTFQj1+OhizkqCaglmysZG5We953HupLLHR7kLXd5o0ac5Xo6v9yCZj1fumBE+P3jGnh4CEtzLVKvjZy3p2X2YjbpSIIHcYHTk5T2G8dq4xdOEtGQ/fR6btxAExG+38roEAL3jJE40fEBtue2grWCF/zOPZqPOVneOafDA9nI9PSnlmephgJ5vjufa3zfP2lew0CI8/iPJcc4yoDZO54eu3Mt8ymloyqK6ATENsQh4RDzooMkGlq9VDcTjaAE0kZizXBlWvV/giVGamNDJI2q0AMI6UT74Lkbwgke5ukqoVL6EntVR X-MS-Office365-Filtering-Correlation-Id: 0fc9e65d-7bf7-4f46-ddfd-08d40cc1ee88 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;31:FeQNlDbTilkr+/lVv6SXor2+fiw89HpOQKGpBZWDvfSHyEVB87TOoLUhbUtpfMG4xxCbQwTPkobPCIvUyCPLN7Ui4xslIuHXB+KvFjsfDZ6F3vgHc689bk5B9EHFVtw4Hy+88CUiNim/jJL8lG7/vQSrcXIh9euRdKSulTIkM+ked7YMfjf5AVnKwN3Ot9IapyUCV90ZheksGF6Hhkg21Su2Fov6MlhRbwxYUs/6cXio3F82V6+35HFXngoKN8e7;20:L/Aq6QpgKtID2TxFcQ6/7bxANHWlIqe/9p3tg8pJkHdoZIKrB/iOs1Odccm8xnjGyVge+fKxx3huCyRUp5DsluIRDn4Ggw6yNrJiHytClmJUkzLtp85yrTSCTO72VOLrpsi9854aIg/RKDoLcRZwWsMTA+KTJz/jNNNx60jAmyfbSp4eVS8wTgiGdGE2spwVGjkmTk8gMXMoUFbDerirdu/ONpW+0qOLr5BLGwwsKl9CD+SUXXMqkOV6/yQTmIDJFbWKVxobYpJ925Pw/Bu2SlZ6mKu0a5XX+pzulg967axxgcetLh9Gt7BpKEYpear7dGQ6hAI9MGYdxMps0C0WTkXSOrwOOdnsLYda2h87cvu6xudAURHnjU7KXzlkDPvCu3hvGYvW/TeaSsg4TukibLSSfgYiD7/2hkBPEbBjQuEZVeu8Qx87vm4LDHUu+3VVtZp82ojL5P0MrRTnu+j3tl9YYvGxLVjJ3ILRHY+BzeSRhGHJP9Racf4kn93BWa8V X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6061324);SRVR:HE1PR0701MB1884;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;4:42GSD9E/mCp7OC/aS8nKqFeubQx2xyYVx0MGNrj81grpXgCrBc26cVCOYPGVoRTUmPxkql0Xu8aINyDDLlknbcGnJpXkxbBBSP4SCQjZVJc/Nz50RRdi9SitHbQ+Z3g6871aOX3fsU7fT6PMTSCE7+nFOV9oWFhA6U398ufneqrkN/m60DxrA0zeNneV45iTCvnE6X/+8rrX0Ae2Bmdd1+wrO/acy+AYKM/P3YSnWPCI5kPALdLdxokzSOE05qEfNJ9rBunPS1R89db2e0k0as65oAbrAVldrgZ0T+tnli6A4f/DYgsPi1qHG31orOIxWXbwRghmfeI4zQDMCzGhN+WCYj3Hg+WLOHGiQSNwZEwt/WmkDy51He/qiwaI/9zXTn++/4PtnOIUDox2JwUuXyRG23b1Ou8Bni8TBjoOeHg= X-Forefront-PRVS: 0126A32F74 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(7736002)(305945005)(50466002)(36756003)(97736004)(8676002)(68736007)(189998001)(7846002)(83506001)(48376002)(5660300001)(229853002)(5001770100001)(5003940100001)(92566002)(66066001)(4001350100001)(6666003)(2950100002)(86362001)(47776003)(50986999)(106356001)(105586002)(4326007)(54356999)(33646002)(2906002)(42186005)(3846002)(81166006)(101416001)(81156014)(77096005)(76176999)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1884;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1884;23:o+y9ZR1V61CgS89r52T5tbkTUTkzDirwcny7oix?= =?us-ascii?Q?nwCgFBQt2dhoNFaub720VelAyuqtc4uN12Is1QG2G/hi0zwk00c7GbGXJNxG?= =?us-ascii?Q?bm++jS6k9v7I//5v/VeNrK9IcDVn1/lxCMlubUNnFMKh36hxF4hPwvFEHR/H?= =?us-ascii?Q?xLjUICo5N4FdFeY9IlUSrEOp9MRft4C0mxcSm77HiHi6X/SgW0vLQ1HaYyNY?= =?us-ascii?Q?6aYmodNfhDk1bryFxtwl4/woNBF2c7Hz4kJl7QJYfgeuWn6z5MAz6v01avT4?= =?us-ascii?Q?NVnEIv2yOLbs62D7UsByjLSGmkiGyIL+SrWLroRQLEG5LrRHOZY5+8o4pLqg?= =?us-ascii?Q?bSms4QZtx+2gbhimB1rqmTiwQHthsOb8X2ihZUHzYLWD8bUikquNfzYsPPF7?= =?us-ascii?Q?hiVJzg3UIVFmeDVi6so0zgy2T86pT3ZMTsMwnszlmBmx99sKuAaKYpCiDe+l?= =?us-ascii?Q?I5sHlA9V2SigzPygGavgCulX5rMtOaCEUwyMgeS94ladlOo8yEtCu6Mo9UAJ?= =?us-ascii?Q?dQmxTO/QrpHbibAJO5vYKhMirq3hdiccr0hWBeTEsEEjCsn1HWp5YLJQgKgL?= =?us-ascii?Q?T6EhYqd4e1F5C80I9BtmymWhEb4e220JwboNX3UjRInRY4aYShK0mtVq0JvK?= =?us-ascii?Q?qpjGkwzJgcw/FF2L7FRLJg5tNuZHb1hgCdWEsVa3FxQBDsMZklgSDTvY0/R+?= =?us-ascii?Q?xTESk1OGsC273bvwHrsxyMbiFiDcJpDRpnFjgf9xV4E4+2vaYh6YIlD55xIs?= =?us-ascii?Q?i+bz+oGyZEx+/AlqMr8nAe7khBjJ6PvgcR0EQCPBx6nWdvP0LsGRMIng+Vis?= =?us-ascii?Q?tPdSPWChPzsS5Wzm6L3VilV2dRmplT9l4a0qdKas7tzpM7N30kJQnzVj3rxn?= =?us-ascii?Q?cc0tecGOLoJliLupFJATZkgCY1ZKI0B7hfkiXfOmtdPyXdNz0K9KoAmYRhQG?= =?us-ascii?Q?wg+xjgrV2t2nwMTUs8HbSgwEDuGRkprCWGx/o9lRCqig39wslPfQlSMRwBmr?= =?us-ascii?Q?X5XWWiKte8o064gd2Ni+w4xZRWddo/PD5D6NG4L3Z8VedLcWPjoaguyQHMmb?= =?us-ascii?Q?BW86/3bbj4z8HzwQ36JBW3rzPJT7MTAwqdCq7krh7+KVN/oMP8Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;6:hoELjtb9ujayD2fVpZaNRcmSVcmfbf4mAcz1cgaGQwYCdbXNRc2qKKhFr1tw69Lwl+05uHo43m3VEqXshnnl3Nkpb2u+fQD25uyRqjflVjpS8FOCdVrfEta4GL8YUV2WyiAyivF6zt2ltah505bw+OXt+/xxNeA1CYnRNgYL5NEYasEnkcbVaCn/6tZUFNHLxlpBN0rFYXTxIrfmBqPe5+DLfSjfW0cWj62p0gGy8Avf3w7W3pHoaoymABc7iCb29/TPB/lH4yGzEI8VuOsQ2/EzP639ncQ9NB8fQamce67anVO8XM+gqS7kLYh5aLBpKEhTpe5IyH+2d60094JH8teC7tncKbwzymeBcQiKKko=;5:QCViPDZOeVDwqF4NHk7nDlSsi65VORi6lazBHx02Ontck3DybXVmUlAbRLyydhLuRewuDMm3lFj/D7w98gnszfToP5wW4PbxKwKtxGY8rUZuAnXaZ/UD8pecPt1psUs2rihF1wPAjpppU/0JtJBVEg==;24:EqxpQqijjJTCEk7AqFMhlXAm1bEQgZNGZm+hmpRr9Wx259OC3RHXUyCtWGDfFcc4n9OnhawE6vKqorxzH+8I85qb5L2pq8fwfxwxorpRz80= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;7:wZpKSn7ooKTZoa5p2xrzym2Ro0K2mf3XNxb1/N6Y68a5PPTZ1ulEqkKRUXn/NZY9h4JbAijgsxiZKCrYF2mgtSPvgkvo4juseVwyRHD7SyxBQmxyb4fmxtCUcYT5yDJsXC0gWd7vecLRYFF2DSwQ71ACrihlCXXNfU7n0qbnYAXAj192tOT5nKDuHbfLIgQ5LTmM+klQNkuCSU225WYLd0QYc2MwVo0NYV4pwbcPK44Vy+0NnMPG1y9o+tlhzO9bri7+XR5l/2tV0yG+1ebd1rQen4hmY1onv1pp+gX2u8Velhsfl4X8hui1ThYG+gIXEKarWk/XR3mnLLcErYV0Fg+Kuy4vFTNPv6GH1Ngz4Ag= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2016 19:10:42.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1884 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00361.txt.bz2 Yao Qi writes: > Here is the V3 of this patch series, V2 can be found > https://sourceware.org/ml/gdb-patches/2016-06/msg00029.html > some preparatory patches in V2 are already pushed in. Patches > 1 - 5 and 9 are already approved in V2 review. > > This patch series is to address the review comments > https://sourceware.org/ml/gdb-patches/2016-06/msg00305.html > >> Hmm, seeing that we need to handle installing the breakpoints in >> both places, I wonder about making linux_resume just handle >> setting up the last resume kind and queue signals, and then >> end up calling proceed_all_lwps. If that works, I suspect it >> would simplify things a good deal. > > I do something slightly differently in V3. In my > "V2 Use reinsert breakpoint for vCont;s", I install reinsert breakpoints > for needed lwps in two places, linux_resume and proceed_all_lwps, which > isn't ideal. > > After the chat with Pedro, we don't need to stop all threads when inserting > reinsert breakpoint, so we can move the breakpoint installation further > down to linux_resume_one_thread and proceed_one_lwp. I'm following up on random SIGILL/SIGSEGV when using software single stepping/ range stepping with GDBServer on ARM. And I can't see why we don't need to stop all threads when inserting reinsert breakpoint. Since linux_resume will call: find_inferior (&all_threads, linux_resume_one_thread, &leave_all_stopped); This will start one thread after the other. So for example if thread 3 has a single step breakpoint to install this will start thread 1, then thread 2 and just modify the program's memory to install reinsert breakpoints on thread 3 with thread 1 and 2 running. Thus leading to thread 1 or 2 executing invalid memory, thus the SIGILL random problems... Could either of you elaborate on this chat ? (I could not find any reference in the mail archives...) Thanks, Antoine