From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121517 invoked by alias); 30 Nov 2016 13:47:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121421 invoked by uid 89); 30 Nov 2016 13:47:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-languages-length:1377 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 13:47:42 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by (Symantec Mail Security) with SMTP id 8A.B7.32482.B78DE385; Wed, 30 Nov 2016 14:47:40 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 Nov 2016 14:47:20 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by DB6PR0701MB1878.eurprd07.prod.outlook.com (10.168.10.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.5; Wed, 30 Nov 2016 13:47:18 +0000 References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-16-simon.marchi@polymtl.ca> <82c06e7795f785cdff3090bb38880a2b@polymtl.ca> <5a48d12d-c6ab-1c31-53ce-80a85602362b@redhat.com> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , Simon Marchi , Subject: Re: [PATCH 16/22] Class-ify ui_out_level In-Reply-To: Date: Wed, 30 Nov 2016 13:47:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: BN6PR20CA0039.namprd20.prod.outlook.com (10.171.173.25) To DB6PR0701MB1878.eurprd07.prod.outlook.com (10.168.10.150) X-MS-Office365-Filtering-Correlation-Id: c9ebe881-006a-4163-45be-08d41927675f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0701MB1878; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB1878;3:8ajfKTirYYrcMiRJCU1pFtt+MJaZDkFvc3h8bptGXugkO2ZLKr89Et7KsLYkQCC2wQ/3g+19G2tL+VNcg603NOIQPYmPFFH8P26lKseiVb/sjopWLkjifK3m3KYpIkII26nNOgnvi7XermGijXmGZQ31Ka6H8Vm8LoewUeEf+KDBMQpgADP4c4ABx6JqcmPmJa7jGELgCJ268WMwh5JUDZp1W6mnA14VY88tVR4V3SwZ4SiNPOuU5EADOetOd4EAyEXH/r/YqGem4ZFFjfQJGw==;25:Itu1KpEOTuvTNzcptOIRfUGmVLD3TILafiP+rsUOTqfsPAQA+SNPvU9MawTXzz+UR+DrSGpACsegKgIBcHypyZ72iStnt3xxKxSnsos08NQzWdLG4eGarsvSOGWAnjACBXwbLEm4yf8WB65oyXLV5wZmN1FT/COPPZccNI6kLpuCiZp0UWP+qXDv8AGEnaexDz+6VWXxjpzoUIPTn7HjLulF3BfAFu6+lJ/pICKsgb+H1TEJfHtUw9eF/02Oes1T8u634adCM9bv1KMBBZDJY8Xb1weKJUJakG+dXbfycLSZoaTPPtg3ANa+N+C8mUc0C2tDsHiHZEaR1tgh9dbON1qh/JVoA3pMh9jnOGOoLPxFQInDzJsqm6pyDdVDFRuvksWgqKo9VNwD4tJkuZCF9ZCGSKVwE2ZMNcjXTGzVrF7yb/90Kj+Aie6ornzSVUF2k3L1bsCUEUr5AdX9mucUVA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB1878;31:GEzfcn/bgpgWLL7GXS+ZSXFLbvhtcoMkjpj6hv9VZRrc2H+Ht5jZ/e+oa8WlRi2tEPzRhF3L19HAMoZNBqO8+VZWUsFhFSiCN1Qhgwcy8KAuQJ5AbD0f3m3igL529/BAF1tbHwwn4/KFYCP8+EDZFp6Opvbq3LXeiaLjJ97H+WJckPJGM2GhL3WWKHPsX98t/6mAZLkfgWIw1qv+xsJF/KXsh9+lx71tBngsgdY4WWPX+687vIZwNsXYjYDsCdUslqDa5OZo9H4j/0H3p0MXCQ==;20:/mGH4VpYmvQRHLgCneHMquHcsb0K4M3ChrbBkRU1fHaI8LK0zv0y8POq7C9h2mpMwf74tMMvmLsZ5nsNcALUkh+b+r3pIcsWPYwwhWu0DlKEVB0PEAPpRdYVlQOIngvSQoesNuafLzaYj1l4AvacNBe5t4vwdqNEqclXqX5ia45P8OqFG3vwMP4HLQzU1xEzvAJ/LIRB2stWluv6G+QIfisHXmtizt0Eob2GEFI1DgESOfOO1sDc3pE4At5+6o+zoNsS/s20dAQAeHNFKodglEjF68kUJcLTZXkE742x5x31YnshqZg5oAE0N4e052vTaKDuhlayMjAUMJ+kstdcKkfrWarmQ+d90XsWjHxdoHooiNzqJgQ8htEi+uCT1BLIDzNBink/6CP3byZMs51Zqq4Z+eUX8ZnfK1WtE4dKHNMe+5AdtNMI0VfrDCmJf6syW35mNIrLOrHJwmSXRByP/lsjK6FEZ0M91dYaGNTU9ou7xpu0iXU4XGupPonPKDmU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:DB6PR0701MB1878;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0701MB1878; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB1878;4:cO78mPa8KgMrAi5fhBqmKYzDO0qtaG2F2lDLAQKQwCnqtiR6O/7ALJG7JS4EeeZL65Bk3OpXroZ+yKtki58geEnQ1kuH+Ob/ILaaRZA/fQcMRxSCk+6zEc2giNHKOZVtksBbkLnSnf3VDFOiQxEB8ozfYZuXee/U/nOZV0WIWCUkadavNFIIZOzI3mXY4EWg1E3pfrFp/QxLxr2HZfyXo+Ypo3WVXE7stJwLy2939L8GEHGAYDfTQYj+O+7eN01m6B15MnjV2+CRi7773r4IfBaCLlgu/+RYDIVLoZzhYSPjJHh9r774ZE9AR6KCXxngcyTVlrBFwMPsLmtVwJ7oHkUEphS+ru5nwA1VU2qxmFku63KI8O5GXi67YrRtm9nx4KEPqtvxsqRuFvv2s3Nuh+fAUtor3qscxk6J8363UZX4966MScJ2RAZQDMhOrpWglYZLDrLNcpGadl4+X3EiyzepBVBgcoVZ2/e7pxMH48PhTCFiT97l6mni+EnxehKN46+eE1uCrHJif07IpojK12zI6A9lm5fY31gW2OxBp0fjeAQroM/9pZs0HJZFleXlUotXj/TVFRCHXc1WVC0nbhVauU8q9VrM4bD4zaR0cdKoCg3aS7RRBuLZv13GtBBPdQcFRUr8MjSEb1qknTrVBg== X-Forefront-PRVS: 0142F22657 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(24454002)(199003)(377454003)(36756003)(54356999)(76176999)(7736002)(50986999)(5660300001)(110136003)(68736007)(7846002)(33646002)(93886004)(6116002)(3846002)(4326007)(5003940100001)(305945005)(101416001)(6916009)(2950100002)(6666003)(42186005)(92566002)(50466002)(48376002)(106356001)(97736004)(4001350100001)(189998001)(6496003)(6486002)(105586002)(38730400001)(39450400002)(39410400001)(733004)(229853002)(2906002)(86362001)(81156014)(81166006)(8676002)(83506001)(47776003)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0701MB1878;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0701MB1878;23:P3FmW6OXiBtJQseaIriGJVlJghQgx8Hg9P/tLO4?= =?us-ascii?Q?ZHIIO7h2N6/MpzyMIdBi/FZxyFQlde2X5VvYM3UoYXZ8Cu4HicuXcoaxb+71?= =?us-ascii?Q?D2CJK2yrHha3DPnk7Hq3RUaFf3+5nbDBuD0Wa3EjJe4BLk6iYpys4M0BFdpK?= =?us-ascii?Q?B1B9lLz7iOWwA+kpwSfDiLX6PJnPbblRMZonJyxRkFgSbcWu02jYAt+aVbzb?= =?us-ascii?Q?DVUp2ADeivq3sCOfZ/YwY0Wa7Eszef95dlt5/lwU6O/0nowjzJy8oXuGAjsK?= =?us-ascii?Q?amod3jUYFjQ2PxAlkv3QLyHCPoZcmkthL7BATnEQD1i9w7Di1k44psFKguTc?= =?us-ascii?Q?u2Zfom9Jy3GMfFfDXrJuQxGX6/kY8yZWuZUOwkj+srmGvBPp+cwBaEHQPuVx?= =?us-ascii?Q?p8wYsTsdFja5E3VZw7fY/bgNgacAIYr7DZt/WTY4jTCCl0Ub9GLtp/MxTc8s?= =?us-ascii?Q?mUm9uLJ9yrOCiHkImEbf4ZJQ6Vj7Ixb/uAcPeaBpF10ooU7pHXv51D2unMJP?= =?us-ascii?Q?VNKDTnvSOLxDBxnmiUOzVvx5QstjHspBgNLbtA74VXVgKaprtGoTYujSgS6B?= =?us-ascii?Q?2kXIU38LiJkKPPdD++XlV+fKothf5zNNFf1JlQheu+C766SyFmCYrIS9FH1N?= =?us-ascii?Q?kKXrzOq1ccK3q7VdHVkKosuxHUrrJaXASwGHVArzjRSqkLqcHyumpBdLpEcI?= =?us-ascii?Q?m3xPgx0aN9f2WITQ2qCMnUTn1163ElRPvRYJiAt0TKNfx2GDVLGfYbnKhRMD?= =?us-ascii?Q?I+QICItniDYeot3t3Z6ti3/gN/Rk7ZI71rqBPLrvKFmHkyEOAih+MAyuJ9uf?= =?us-ascii?Q?uxzkVsWv6fz98WCmWlSp11pgJPOOdT79DZVfFk8Pis/9SQ7drojtLfzbUABn?= =?us-ascii?Q?5UE0i+l8qTFGPE5xMfrZJAUJWz39qXfTVXYhQKgIcHC6TIRx7ha49QQXGdiW?= =?us-ascii?Q?Pt4mq36alDuV9oQrClPmfc7igaooMIBt9TtO3IVMBgx/PQWGv5/7OPUxO/KD?= =?us-ascii?Q?T+zFxdqdKJ58iy8eGYFBBom9gMGN2ae/Lu6BxTQF9RCrQxgFnpJdRi6Pgm2+?= =?us-ascii?Q?rqkc6cKuE3E/FnG2BEaRd5Mg8fECVjeaBQC3zEHOH1jr76GBTaXzDDBqQmhZ?= =?us-ascii?Q?P9WT81qyoGTd0Kd9MVXqVwIvkNWR3SRhfdcDsae2/td7+AOkDepStlDqyZ/n?= =?us-ascii?Q?j5HkEB0bLdcDEg/B5Q5W4jXOESWsN2P3WzMjMaCvfhGMvtZwFHqAIMwb9IBp?= =?us-ascii?Q?vCvZud0djugDNWunduJg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB1878;6:zMMP2zU1e04ELB3T60Ch9SMv7IfV1zWKy2ex5MDtg1rTBYpoxAGLoeW0IJXkBS/NFJusf0K7fFowHIqbpfkZkrT+5ceEA64qieqHGx2yH7t4V7kd/dg5+3AvdY3Vz5tCkiYzhbTrdAsIXz3gWCW7DWoTC9jbPUyxefJE6eRXwOvOkBDzlqcbMIUOnaBNpYElimVAe6wGKBLUNLv1PBXRYFmJVEfaDKEfVPtjPik6YqZfjaHaAV3xC+R4QBd4TriUP8HeLgCjc6/okoowAZWdcEk7aTVG+cHwl+9JAFi9K4jy8ApkTyar98zIHOKwpbSheuSSdj+BHY9HSgqykCshLyzMy+YMw679h4/I2dKvZIAdbtnmwA1JqHxYaX9TI3E2Kl0l+3lqVfoNCJY+XoJYTKbtK77HH0MwUDspO0F2zjjDOQXYgSwdpcljX825PWpMKqPO1vT5Waa0ZK/+R0bTrA==;5:mZMepkPCtjce3I5eEQl0qTgO8SXwoPhUYS2S1jQEKj68ITqoj6n+R8UZhOl2qMEWy6afa1f2K9Jj/tYX9954f6Ij0wvxM+f6YnjjlRxsyZxbf+CV/8iRE84FmIm2FcLscs+p3YT74BesHivuI0sY0IrnfgoaNJSQAKLrwl9vg7I=;24:Dr2gIFJ5ufbF2sP6PT8ztsSIpX5ZmI9647WYOw+FfBnT3u3wbIQXRl2MIsb2pP3fUvgrMDbae6tzWIpM4zTu2X3sgGyjHs/j+2Q9/ChZlw4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB1878;7:kNMDxJYbz/Mu8ksGm9PqYw7toDqWtaCipKranXaxgBhBGecO6RR6k9st53WZO6brfT/c0dn892xII5lHyGW+BtW/5+fZE5q/gSfEsDm4nD+tcrIMdbKqLy3kyWOo3nQOMpLoL+netQhvwBGBSp1EE8szQWQBjw6jL6ruezA3GPR5DkDt8gMK9CKV9XzMCNQyzgegnGQMryZhS22HpN+00EyDSk2oJS5GSgk8aKyJp4Eps/liUkWxLsXEA6+BKX7gZImAJXve7z7B6QBeEyhyzboZmxCQCeE6SpV+eUL2pKUDC0FG9KceUEPGHfiMMAEflSaz86YobTSJ4/MBmPXIx4AbRNH0833ucJIz15GndzM+1gO5cX2UTeR5ox7nruScPDvRjV7iWbOkpQg6GGWMwBU+k2bMuI4AAsIh4azWTCdTwjn50bPCpqaWCdUh3VD0kWYY69kZbivbTViD0gfxBw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2016 13:47:18.6280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB1878 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00987.txt.bz2 Pedro Alves writes: > On 11/30/2016 12:40 PM, Antoine Tremblay wrote: > >> Note that in the discussion I argued that it would be a good idea to >> keep it for single argument constructors, but that I though that there >> was little chance of confusion for multiple argument constructors like: >> >> ui_out_table (int entry_level, int nr_cols, const std::string &id) > > Yeah, unless all the arguments except the first are > defaulted, like: > > ui_out_table (int entry_level, int nr_cols = 0, const std::string &id = "") > > then it's effectively the same as single-argument constructor, and > allows implicit conversion from int. > > There's at least one such case in the series: > > ui_out (ui_out_impl_base *impl, int flags = 0); > > Maintly harmless, given the types involved, but still I'd > think it better to be explicit. > >> (See: https://gcc.gnu.org/codingconventions.html#Conversions) >> >> I'm starting to think we need to document these things as the GCC coding >> conventions may not be exactly what we want and reading the ML there's >> more and more questions about this... > > In this case it looks like it's documented? Yes this case yes. I was thinking of https://sourceware.org/ml/gdb-patches/2016-11/msg00973.html Also we allow the use of dynamic_cast while GCC doesn't... I'm sure other things will come up ?