From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>,
<gdb-patches@sourceware.org>, <qiyaoltc@gmail.com>
Subject: Re: [PATCH v3] Enable tracing of pseudo-registers on ARM
Date: Tue, 23 Feb 2016 19:34:00 -0000 [thread overview]
Message-ID: <wwokk2lv8bmd.fsf@ericsson.com> (raw)
In-Reply-To: <56C7796B.3030504@redhat.com>
Pedro Alves writes:
>> +
>> + return double_regnum;
>> +}
>> +
>> +/* Implementation of the ax_pseudo_register_collect gdbarch function. */
>> +
>> +static int
>> +arm_ax_pseudo_register_collect (struct gdbarch *gdbarch,
>> + struct agent_expr *ax, int reg)
>> +{
>> + int rawnum = arm_pseudo_register_to_register (gdbarch, reg);
>> +
>> + /* Error. */
>> + if (rawnum < 0)
>> + return 1;
>> +
>> + ax_reg_mask (ax, rawnum);
>
> Hmm, seems to me that gdb raw -> target raw mapping should be
> either here, or perhaps even in ax_reg / ax_reg_mask?
>
After more investigation, this can't be in ax_reg / ax_reg_mask for
pseudo registers as this function is solely reponsible to encode the
right number here.
> Consider the case of an expression requiring the collection of
> a _raw_ register, thus not even reaching here. Looking at
> ax-gdb.c/ax-general.c I don't see where is anything mapping gdb raw numbers
> to remote/tdesc numbers? So how does _that_ work? Are the register masks that gdb
> is computing actually wrong for the target, and things just happen
> to work because gdbserver ignores them and always collects all registers?
However yes it should be in ax_reg/ax_reg_mask for non-pseudo registers,
but this is not the objective of this patch, I suggest that such a
change be the subject of another patch maybe coupled with better
gdbserver handling of the R action.
I will send a v5 with the ax_pseudo_register_collect inside the
arm_ax_pseudo_register_collect/arm_ax_pseudo_register_push stack function.
next prev parent reply other threads:[~2016-02-23 19:34 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:45 [PATCH 0/4] Support tracepoints for ARM linux in GDBServer Antoine Tremblay
2016-01-07 17:45 ` [PATCH 4/4] " Antoine Tremblay
2016-02-08 14:45 ` Antoine Tremblay
2016-01-07 17:45 ` [PATCH 3/4] Enable tracing of pseudo-registers on ARM Antoine Tremblay
2016-02-12 15:14 ` Yao Qi
2016-02-12 15:54 ` Marcin Kościelnicki
2016-02-15 10:27 ` Yao Qi
2016-02-15 10:57 ` Pedro Alves
2016-02-15 14:46 ` [PATCH v2] " Antoine Tremblay
2016-02-19 16:33 ` Antoine Tremblay
2016-02-19 19:29 ` [PATCH v3] " Antoine Tremblay
2016-02-19 20:06 ` [PATCH v4] " Antoine Tremblay
2016-02-19 20:22 ` [PATCH v3] " Pedro Alves
2016-02-19 20:32 ` Antoine Tremblay
2016-02-22 11:51 ` Yao Qi
2016-02-22 16:51 ` Antoine Tremblay
2016-02-24 18:11 ` Pedro Alves
2016-02-24 18:21 ` Marcin Kościelnicki
2016-02-24 18:33 ` Pedro Alves
2016-02-24 18:55 ` Antoine Tremblay
2016-02-24 19:02 ` Pedro Alves
2016-02-24 19:02 ` Antoine Tremblay
2016-02-23 19:34 ` Antoine Tremblay [this message]
2016-02-24 18:20 ` Pedro Alves
2016-02-24 18:47 ` Antoine Tremblay
2016-02-23 19:41 ` [PATCH v5] " Antoine Tremblay
2016-02-24 19:12 ` Pedro Alves
2016-02-24 19:25 ` Antoine Tremblay
2016-02-25 10:35 ` Yao Qi
2016-02-25 15:33 ` [PATCH v6] " Antoine Tremblay
2016-02-25 17:59 ` Pedro Alves
2016-02-25 18:19 ` Antoine Tremblay
2016-02-26 8:34 ` Yao Qi
2016-02-26 13:00 ` Antoine Tremblay
2016-02-26 13:03 ` [PATCH v7] " Antoine Tremblay
2016-02-26 14:14 ` Yao Qi
2016-02-26 14:57 ` Antoine Tremblay
2016-02-26 14:59 ` [PATCH v8] " Antoine Tremblay
2016-02-26 15:57 ` Yao Qi
2016-02-26 17:45 ` Antoine Tremblay
2016-01-07 17:45 ` [PATCH 2/4] Use the target architecture when encoding tracepoint actions Antoine Tremblay
2016-02-06 20:58 ` Marcin Kościelnicki
2016-02-11 13:02 ` Pedro Alves
2016-02-11 13:21 ` Antoine Tremblay
2016-01-07 17:45 ` [PATCH 1/4] Teach arm unwinders to terminate gracefully Antoine Tremblay
2016-02-12 14:46 ` Yao Qi
2016-02-24 17:57 ` Antoine Tremblay
2016-02-25 11:44 ` Pedro Alves
2016-02-25 13:15 ` Antoine Tremblay
2016-02-26 9:12 ` Yao Qi
2016-02-26 12:26 ` Antoine Tremblay
2016-02-26 14:25 ` Yao Qi
2016-02-26 20:10 ` Antoine Tremblay
2016-04-06 15:54 ` Yao Qi
2016-04-06 16:30 ` Pedro Alves
2016-04-07 16:33 ` Yao Qi
2016-05-04 16:24 ` Yao Qi
2016-01-11 12:17 ` [PATCH 0/4] Support tracepoints for ARM linux in GDBServer Yao Qi
2016-01-11 12:56 ` Antoine Tremblay
2016-01-11 13:41 ` Yao Qi
2016-04-26 19:11 ` Antoine Tremblay
2016-04-27 8:00 ` Yao Qi
2016-04-27 12:07 ` Antoine Tremblay
2016-04-27 13:57 ` Yao Qi
2016-04-27 14:41 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wwokk2lv8bmd.fsf@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).