From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48633 invoked by alias); 25 Nov 2016 14:28:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48619 invoked by uid 89); 25 Nov 2016 14:28:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1449 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 14:28:23 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id 1F.BB.04375.58A48385; Fri, 25 Nov 2016 15:28:21 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 25 Nov 2016 15:27:56 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by VI1PR0701MB1886.eurprd07.prod.outlook.com (10.167.197.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.5; Fri, 25 Nov 2016 14:27:53 +0000 References: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> <20161121120822.GA28605@E107787-LIN> <20161124215510.pbsobdtj6niycjhd@localhost> User-agent: mu4e 0.9.17; emacs 24.5.50.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , Yao Qi , Subject: Re: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s In-Reply-To: Date: Fri, 25 Nov 2016 14:28:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: CY4PR03CA0011.namprd03.prod.outlook.com (10.168.162.21) To VI1PR0701MB1886.eurprd07.prod.outlook.com (10.167.197.22) X-MS-Office365-Filtering-Correlation-Id: e6fc8203-aa50-4688-4d92-08d4153f3eea X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0701MB1886; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;3:CZ/79DgzaelVWmAbpLxqmRcatfJWhi8cYvXMiu2PZ7cx/27kCiFudeytZIPf0BInfGqeQJpUX6mINrpu9MXnMT8/2zIGNjjROn3sEfAvem9YVgm7fL2zTrInswlX/9LbjQniMDP1spPtUsgH2n18Dj8zkR4/4s1YH5X0vnlgeIH4AevnFYNrUCAQRG5q9/j8s81UsWHRe3qBQsIC0eFo1Z38+S/2SYrYCIzHOwi6Z+CYzbQ2sWwYVQSmhQ9ZdYI9xrUhvXGQE/dN0kUYsJQpNQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;25:Hq2sS9zRgcz1yK1m26E0k9uR6UW6bUlVKZRYyK+dqd2HDKEDcz11ujOQzm9ahV2sCUpwgE/8CVPbSQ5sUIxDuMWmw6RdiKQFIfKTERjka4xE/tAqdM0AYXbmR+euA6ovLDV0htkUs74QYAa0WnimEoX1C8xb97qh+YfQI4JHxX60xWDG1Id9StVi4ZuU3adgUmo0xxlUcOyiJL7dnK0/Mhbo3Zk0hh02KSUYZmgTqp6C792GY+FRV878j1TYvZH4wrvpTY8rXC2lB2rXeIvwns92DB35lrQUn+2EZl2DMmW9iNl+kfzj3Tomp9P+zr8XDyCom/7Ek/PZTaCXcRyINXehUxjFhIuThPk6Ad8sMf7yv2MV1JnrsIyOlT1uk4qp3qem5jvJ59Z5YpNS0nXH4Fk8KcRztrBHhMYmOSNT5HxM0CgVWVuyJNotgAY6AXMMtmo09UMt74eT1BwGvp9OwHTz5dXtU3LpFfNO1pTmVYonyBGnjYH6Tz4LFDoPMulUtZEP1sh+Ys4nY5vrmMptg3vOKHl+zwVDFK3rOYKt2S8NR/wRmPzZ/e7VaFUTuR0g9ua77emNNeLScoMEbAh7f63Jdkpq+nigINeMK4F5TGuIC00efQQIN1Y8iRtriAk0kE4MnPNsJ6iYbJIfxM7kCfpGuVHtIAFDbYkuWWnaLLD0pTG7GVnnjmODIw9pvERndsvLQ9I/SKxDhFV+wQovjubzb0ThXjgoCouOeeF2Kt+jcGz61tMiZv9BUXZSpP2d X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;31:amoK+JPAiwH/GDLQ+DBRjy4T96ncBgdltrLVHkxP9RuL2XVDK6mla2vvpCeC48NZDXLfySavI9rZ879uz4aCSl/Mope54WnVQ34zlfvqYcxcWvQ1ICxEXL6FBd1065nLstURgOI25LUvZpjBXde6ngCvSlhw1M/A7uucxLkJRVOe4Q4g0ybY63L949W+WC+D1TsxNjqd4SyWD830WF7c2SZU1KJJ18ACzLytCuvbkWgmzgHa+c27jTPgb+SG4Ru3Xdj+A5YtIYJhz8Htka3o9Q==;20:Hq7tWU/m0Xq7OlUWSKJgH7V6f0BdBWFShIOKHFFO9DcKzNDnvzc9YuWbyUNpU3wP5+DQ93hg2TqZBzqpCUZKznY47lk+8T4p9NPT9BSZ5Ljtglp5vFe3onVEjFrAhkH78MsgAX9dhyzWdRpVP2osz9swcdPJar0BpxGYLccy7LkkTpDREUrBctxCKq6IL3BYA8swLZAhgQuFd44Ydk6IqFWloTgRyPuSnLAr6PSKvmNwOEoXmOQxTFKp56DWdoMyAmXgPpN7ottsgXj44xmwTqwDfKnqSCttT/J8e4GS72NfiQWOab/vKNvsj39YKB8BqpUT9eEIsPC632A0NKDyFg54l9pcaUtld4A+6LlZVnYOwDfQVQmJYUgeynkuFiLELL0qa/SiUnmh+x6QiBXeTMxFaExPKRsf6Nkp2F5iDgeGkU07xXoINAvdE9C3mdmKykLd9AI4KtUxY+gYLPtxzwhXe/omtgmxjvCKlpCG7dGVqp+8QWbHLQfFNgClJY7x X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6045199)(6040361)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6061324)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025);SRVR:VI1PR0701MB1886;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0701MB1886; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;4:hHnMnUq14ROuAPexc7I4FSwAa/UIL5Jw1Eq7FELbJ57H4wHKLwUDvS45nS0x3hTJD4Dm+KEXKVLOHEp+b4GJ4Xg0aDgzb9IZ5Y2GtQFfJpRxniaqRcHl5G689dKVfLvWx2MZIt4zvlx+RTQqk+UM9L0dajkU8l+sbF2JUXMtf+Azs5/aMmR0ulOD8ds98JdFKtJFqb0hEO9BN3RB515LwoxTXq5y9b23RYX21400AIbadnBU+MUH8wXu6oxi/jjJis39ufjC5RRRL8ab+OlDRS/uZc/gDnBVfi70qkTGs4bnDW6JyhEo3jFUhDVnmmfD6O7w6Gm323Z8AkkN9YSi5Z+RhYdnwvUjdBaMvcq+5cucevh9i8ZmDsEPQynODFEUwUAahjRzcnvOajcO75XCuBUx0rK6FHPNoy40CdEW7hVi+lTdhU3jJTScLEdHmK4l7OWwKGgkREiy/7pFqV6+Ju6VmaDYKaSwr9GAc9Cd0ZnCCNhzis2WcN8oJ7fFylIF+0phNTOarKvTRuAEMzxSV3WtsMR3LBOsMSQt5UpAj6zcSYxtDU3Sxql8yA8EvOQlA2NxHP4GbFy3C/qaqToHRRrtuP7UXyFj8zFL3QdEw+M= X-Forefront-PRVS: 01371B902F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(24454002)(377454003)(199003)(305945005)(66066001)(39380400001)(5660300001)(7846002)(4326007)(38730400001)(7736002)(6916009)(39060400001)(8676002)(2906002)(81166006)(110136003)(39410400001)(39400400001)(81156014)(6666003)(2950100002)(229853002)(77096005)(39450400002)(83506001)(5003940100001)(48376002)(50466002)(4001350100001)(97736004)(189998001)(33646002)(50986999)(42186005)(76176999)(86362001)(36756003)(54356999)(105586002)(106356001)(101416001)(93886004)(6116002)(68736007)(92566002)(3846002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0701MB1886;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0701MB1886;23:kivB99QpXLqrfA70eJ6huhU7OVmouQ0MYdG5dul?= =?us-ascii?Q?jqh0O2vfeR22UQIeZCs5Gg3raoUYj8N5suOjXEgxpr5hmTKpxea1BBwqA4Q8?= =?us-ascii?Q?fJkaYhLrtvpGk8Aq6Z/fYGXD2Q0aOloAE9E1VF0bxk8zU22X0lHK7pxGhaAX?= =?us-ascii?Q?Ambw3R7su++JRQgayHQ8lZ29KGTW31e842Z29F/dy/G9nfG8Fcw6Kiy0jnET?= =?us-ascii?Q?RLZ5RA1mKU2tz96StNf8den6/yufomyiQ3XGT4NNK77gAVfhC8LffkysMjd7?= =?us-ascii?Q?KIPR8bJHmgFuJTXNxc5vh9xT2PgOTWwSz13zJT2sylZFib4ShSO3+tr4Llqh?= =?us-ascii?Q?eCahhasQhRM1tGsUppXDk/xmOEjC3w2RaanNvbhWQlN8JeldLZvqH2458FFG?= =?us-ascii?Q?P3dBv3XImZiOGTuK+EFdMkaXNww71XfyKzpzJKgUyUlc995ZgwaqesoB/c8/?= =?us-ascii?Q?rYHY2rD3fbMmM3W00oL1FgBJICzbUvXh+zikOsS27XT3/R6glN0DmjdwtfEm?= =?us-ascii?Q?OxRJQQ5qMKMBA4YaC7jw/Ql1VLa8ntnUYHI1px+XbXzSiodKbu13BBgaNJI1?= =?us-ascii?Q?nYlI9XJYMIH1IKgoy0z8tDz+uuTkG7ayWY3SiFYgxCp71JHy2xxk0d/R4baR?= =?us-ascii?Q?zFNXEJrShewz3EZrdHjWfROdleJZHHab4nHL2T6Ugaf9/uBkIXmuZzaRrtcs?= =?us-ascii?Q?lsltLInqpBz0lqHjBvCslt4joiFx5WDmnAdJOqp/bjvA8/JHS63ZmPpPxS6L?= =?us-ascii?Q?11CTFgJP1w3phcB7O3Z2S0LBmJSVzs7qXdmJaJTwrNnGLCdLzQOzj35M1NPq?= =?us-ascii?Q?tZmkjWh4BuT/e0ERczBpx+i9trVmFCAzrEEEcYloKboFReOeo2lAGWVDiYAX?= =?us-ascii?Q?+I/LCoRzYYyK+mRmU8GiTwYkQ/uKuw4hWKIgvKwOZnF1tpRQ5RQkW1Mvt0l3?= =?us-ascii?Q?RlIfXOIYB5UFZrcRGgzCAIIXHu3Pe4EV+Qq0T6mzQ6cW5mpZBJtghQWkP4yg?= =?us-ascii?Q?FP4PcEkARUpCzjIgcbsSKTH4DFufh+SuV8VqaczKg76f/aZ8iHu66RHhabcf?= =?us-ascii?Q?+FrluAHlLMu2Wv2hSfdarvfYWnbxy5SGAaLo5aiEv1dYLwRYAzwrz5337feh?= =?us-ascii?Q?reQDJzAKBmAKoTt+maeY8D5BWVfhE4Xlb3yo7+o6qzYmX7nWkcnIZ3Azb3wY?= =?us-ascii?Q?JyMhRbUxWz09pHkSUEdEzChENWQCYOXH2ACuyNsiE4CF+Nn4r4PcI5NirNtH?= =?us-ascii?Q?EFxqjFYD+4VWVJTe0cAl+bPHF9rzuW1BDU1MYO0GO4TolXVC+1P0zQOHZuTS?= =?us-ascii?Q?9mg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;6:2X4G6NStbYmXA7WFJc85U0dsnkUntNil+S4najDs9pge0oF0KoVpHUZgz5/wWp5cQFubV1daYg2+sLsWCD1FSc5tioTFCRO/gZYrs/AUiHuza0MR2vG+gQNda22o4eBLt5IpXQt6xbyaEpe9YQ04vtvDYHwm05bywEtGPc7kIg9Rtfmf4v+qEyt/2eVerflChtgPvJ7iNYHwXd05TkorOEOXlgpDX/AGf67HKNBtqeqxiIwEunAUu/bXvCM2Fc3vdPdR+jRTUfVbYDtBpp+nyZac2vHpAex2u4yQBRMcm7rt8ipmjD+bGA1B7P7tNSvykNla+8/aRKVikMOZ5qIT9lhST2Kr/gnoMr+uM0hbQ8Io8jSy8nJ4SlShdiYq4tAWdnrnpdA9Tr1SUIa6miFHQB7ouiutiP+fuB28BgE1tex8ycAtcpvnKYMyO6oDFjGhHVu37c0cL0fRlyEic9gsaA==;5:elRMgZ/NGdXaX2Dzv5u3Zo5fNt1IpQ+3QX6HMa1LFNksHgyjOJa6oQfNBaToYZww9MA5NSrCUGhVbmmfSYAAQCIrwydyo5yMLLAwtJkF4KXl2mEVb8SXjl1Fu+NRo1EbUzmQu8HwgWclhB/19kGwRMnb602r1LekQYhEFqB6WhI=;24:vrl5h0/lIqQCsbf8KOtmPM4Bvv1POVFuycQuTTKdKRutfIHoUrMu9BNkYOliBjLVk3lSXQmmzPIQM/bdY7mAE4YDaJJX6FehLYoDx88Ye1o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB1886;7:MyjA935taaQhqJPCK2P0v2Y5HsncGfjKSZP1X36+iPJ/WbLSz6GqdX/gizDkSIupXByTXU0F6e3IRQido+cPyIQB/KGW6TudN/zn1oQEkDABNIOnZRyiMZx+PrQ1HyQk4PrW/GiC4nM+BuYGYz9/JDyTNNYSgECwaq5qw4CWdlkXGlEXipB9moMydapQ2gX1CXo92o8mp7ZXb8J3UVIAEAua3GaKJ0rywgQ69id+vY5amdHlymDWiHWQDAG9iysTcEMj6cf1R7vaNKup/ppGbblCm+ZmKNAVZiGFfVEx8bdxZT9o49mJIFmf5era0X+hJPB5vE4LCjFkmv4bnpZ71PxPkEVrgHpnGQNEYf+/siulWUPdTGZpwNmW4ubWDaFp7P0TUS62VFuKw3lOTaHfC+sJ17XwRJ9enpej9wKVQKEvmBnnI21leI4dsRbNyl+l/HCyVflzlKu1GPMLMrWC0A== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2016 14:27:53.6638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB1886 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00809.txt.bz2 Antoine Tremblay writes: > Pedro Alves writes: > >> I'm behind on this whole discussion, but, the comment below >> caught my attention: >> >> On 11/25/2016 01:12 PM, Antoine Tremblay wrote: >> >>> In fact thinking more about this we may need to remove all breakpoints >>> at any pc since get_next_pc may read memory in other places then the >>> current pc to deal with atomic sequences for example or for other >>> instructions too. >>> >>> If it reads a breakpoint in memory there it may come-up with an invalid >>> next pc. >> >> How can that happen, given gdbserver's memory read routine takes >> share to hide breakpoint breakpoints? >> >> I.e., read_inferior_memory -> check_mem_read. >> > > Indeed, this is because arm_get_next_pc uses (*the_target->read_memory) > directly. > > This should be fixed for read_inferior_memory indeed and it would solve > this issue, sorry I was not so familiar with the check_mem_read hiding > breakpoints/fast tracepoints jumps. > > I'm not sure why it uses that directly at the moment, looks like a plain > misstake but I'll dig a bit more. > > But it's just what we need this may easily fix that issue in particular! Turns out this a problem in a few places on arm and on other arches too, the only place you should call it directly basically is {arch}_breakpoint_at. Otherwise call target_read_memory. I'll send patches for that. Thanks! Antoine