public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>,
	<gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/4] Add variable length tests for emit_ref in trace-condition.exp
Date: Fri, 27 May 2016 13:04:00 -0000	[thread overview]
Message-ID: <wwokmvnbveia.fsf@ericsson.com> (raw)
In-Reply-To: <f405088b-5621-234b-5080-400c92de2f66@redhat.com>


Pedro Alves writes:

> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>> This patch add variable length tests for emit_ref by reading the variable
>> passed as argument of 8 to 64 bit.
>> 
>> gdb/testsuite/ChangeLog:
>> 
>> 	* gdb.trace/trace-condition.c (marker): Adapt signature to 8 to 64
>> 	bits types.
>> 	(main): Adapt to 8 to 64 bits types.
>> 	* gdb.trace/trace-condition.exp: Add new tests.
>
> Looks OK to me, but same comment as previous patches.

Note that I don't think the same comment applies here as tests check for
1 or 2 frames only. So you could not get an unconditional error.

test_tracepoints $trace_command "arg8 == 1 || arg8 == 2" 2

For example will test 2 values and collect 2 frames max to pass.

Thanks,
Antoine

  reply	other threads:[~2016-05-27 13:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 17:03 [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp Antoine Tremblay
2016-05-17 17:03 ` [PATCH 4/4] Add tests for 64bit values in trace-condition.exp Antoine Tremblay
2016-05-27 12:08   ` Pedro Alves
2016-05-27 12:36     ` Antoine Tremblay
2016-05-17 17:03 ` [PATCH 3/4] Add variable length tests for emit_ref " Antoine Tremblay
2016-05-27 12:05   ` Pedro Alves
2016-05-27 13:04     ` Antoine Tremblay [this message]
2016-05-17 17:03 ` [PATCH 2/4] Add emit_less_unsigned test " Antoine Tremblay
2016-05-27 12:02   ` Pedro Alves
2016-05-27 12:36     ` Antoine Tremblay
2016-05-27 12:00 ` [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp Pedro Alves
2016-05-27 12:35   ` Antoine Tremblay
2016-05-27 12:48     ` Pedro Alves
2016-05-27 12:51       ` Antoine Tremblay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wwokmvnbveia.fsf@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).