From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92539 invoked by alias); 25 Feb 2016 18:19:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92517 invoked by uid 89); 25 Feb 2016 18:19:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 25 Feb 2016 18:19:23 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 92.97.32102.F854FC65; Thu, 25 Feb 2016 19:18:55 +0100 (CET) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 25 Feb 2016 13:19:21 -0500 References: <861t81cc2c.fsf@gmail.com> <1456414378-1918-1-git-send-email-antoine.tremblay@ericsson.com> <56CF40EF.8090308@redhat.com> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Pedro Alves CC: Antoine Tremblay , , Subject: Re: [PATCH v6] Enable tracing of pseudo-registers on ARM In-Reply-To: <56CF40EF.8090308@redhat.com> Date: Thu, 25 Feb 2016 18:19:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00821.txt.bz2 Pedro Alves writes: > On 02/25/2016 03:32 PM, Antoine Tremblay wrote: >> In this v6: >> * use https://sourceware.org/ml/gdb-patches/2016-02/msg00786.html to map >> registers to remote registers. (This is already in master) >> * Fix test changelog >> * Test is already renamed, update patch. >> - >> This patch implements the ax_pseudo_register_push_stack and >> ax_pseudo_register_collect gdbarch functions so that a pseudo-register can >> be traced. >> > > FAOD, I'm happy with this version, if Yao is happy. > OK. I'll wait for Yao's review. >> dummy (void) >> @@ -37,6 +41,7 @@ main (void) >> { >> /* Strictly speaking, it should be ymm15 (xmm15 is 128-bit), but gcc older >> than 4.9 doesn't recognize "ymm15" as a valid register name. */ >> +#if (defined __x86_64__) > > The comment should be within the #if. > Fixed, thanks. Antoine