From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131786-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 54898 invoked by alias); 27 May 2016 12:36:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 54871 invoked by uid 89); 27 May 2016 12:36:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: usplmg21.ericsson.net
Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 May 2016 12:36:51 +0000
Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87])	by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 9D.0C.03614.C2F38475; Fri, 27 May 2016 14:35:56 +0200 (CEST)
Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.3.294.0; Fri, 27 May 2016 08:36:48 -0400
References: <1463504594-4419-1-git-send-email-antoine.tremblay@ericsson.com> <1463504594-4419-4-git-send-email-antoine.tremblay@ericsson.com> <a1c89256-fc54-5845-1abd-4a18c9c9d531@redhat.com>
User-agent: mu4e 0.9.17; emacs 24.4.1
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Pedro Alves <palves@redhat.com>
CC: Antoine Tremblay <antoine.tremblay@ericsson.com>,	<gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/4] Add tests for 64bit values in trace-condition.exp
In-Reply-To: <a1c89256-fc54-5845-1abd-4a18c9c9d531@redhat.com>
Date: Fri, 27 May 2016 12:36:00 -0000
Message-ID: <wwokpos7vfrz.fsf@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2016-05/txt/msg00492.txt.bz2


Pedro Alves writes:

> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>> This patch adds tests for emit operations with 64 bit values. It takes
>> special care to avoid mistakes that one could make on a 32bit architecture
>> using 64bit values.
>> 
>> gdb/testsuite/ChangeLog:
>> 
>> 	* gdb.trace/trace-condition.exp: Add 64bit tests.
>> ---
>>  gdb/testsuite/gdb.trace/trace-condition.exp | 36 +++++++++++++++++++++++++++++
>>  1 file changed, 36 insertions(+)
>> 
>> diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp
>> index 8c770f4..4e129e8 100644
>> --- a/gdb/testsuite/gdb.trace/trace-condition.exp
>> +++ b/gdb/testsuite/gdb.trace/trace-condition.exp
>> @@ -163,4 +163,40 @@ foreach trace_command { "trace" "ftrace" } {
>>      test_tracepoints $trace_command "(42 >= 42 ? 0 : 1) == 0" 10
>>      test_tracepoints $trace_command "(42 > 21 ? 0 : 1) == 0" 10 18955_i386_failure
>>      test_tracepoints $trace_command "\$trace_timestamp >= 0" 10
>> +
>> +    #Test operations with 64 bit operands.
>
> Space after # ?  More instances below.

Fixed, thanks.

>
> (And same comment as previous patches.)

Yep.