From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2088 invoked by alias); 11 Feb 2016 16:32:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2007 invoked by uid 89); 11 Feb 2016 16:32:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=you!, you X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Feb 2016 16:32:26 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id CE.9C.32102.187BCB65; Thu, 11 Feb 2016 17:32:01 +0100 (CET) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Feb 2016 11:32:11 -0500 References: <1455029644-6197-1-git-send-email-yao.qi@linaro.org> <86egckqztq.fsf@gmail.com> <56BB6ADB.6070909@redhat.com> <86a8n8qxyp.fsf@gmail.com> <56BB7512.2030507@redhat.com> <8660xvr1wr.fsf@gmail.com> <56BC829B.8060102@redhat.com> <864mdfp9b3.fsf@gmail.com> <56BCAE02.7030803@redhat.com> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Pedro Alves CC: Yao Qi , Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned In-Reply-To: <56BCAE02.7030803@redhat.com> Date: Thu, 11 Feb 2016 16:32:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00369.txt.bz2 Pedro Alves writes: > On 02/11/2016 03:15 PM, Yao Qi wrote: > >> I think this is better than 'make gdbserver use extract_unsigned_integer', >> which looks overkill to me. > > I think it's only going to bite us back in the future. > > From the perspective of potentially making it easier to share more > code between gdb and gdbserver, I'd prefer that. Would you object it? > For what it's worth, I would also like extract_unsigned_integer to be in common and have the bfd_enums moved if possible. >> get-next-pcs stuff needs endianness in GDB side. In GDBserver, >> endianness is not needed. Note that I dropped BE8 support from my single step patches, but should we ever want to reintroduce something like that endianness would be needed in GDBServer. > > The get-next-pcs stuff does have endianness bits, but it works > around the lack of 'enum bfd_endian' by hacking it through an int instead: > That hack is indeed unfortunate. >> >>> patch series that handles that by moving bfd_endian to a separate header. >>> I've pushed it to the users/palves/gdbserver-extract-unsigned-integer branch >>> as well. Thank you! Regards, Antoine