From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71798-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14525 invoked by alias); 7 Apr 2010 04:37:29 -0000
Received: (qmail 14517 invoked by uid 22791); 7 Apr 2010 04:37:28 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 04:37:24 +0000
Received: by vws14 with SMTP id 14so366313vws.0         for <gdb-patches@sourceware.org>; Tue, 06 Apr 2010 21:37:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Tue, 6 Apr 2010 21:37:22 -0700 (PDT)
In-Reply-To: <20100402173924.GA5329@caradoc.them.org>
References: <20100304180219.GA10826@intel.com> 	 <20100304180408.GA10869@intel.com> <20100304180748.GC10869@intel.com> 	 <20100304180901.GD10869@intel.com> <20100304181003.GE10869@intel.com> 	 <20100306222250.GG21133@intel.com> <20100312172541.GB6643@intel.com> 	 <20100329010935.GA27237@intel.com> <20100330164833.GB13521@intel.com> 	 <20100402173924.GA5329@caradoc.them.org>
Date: Wed, 07 Apr 2010 04:37:00 -0000
Received: by 10.220.108.106 with SMTP id e42mr4053267vcp.79.1270615042095;  	Tue, 06 Apr 2010 21:37:22 -0700 (PDT)
Message-ID: <x2r6dc9ffc81004062137z1457a33v7eda8aaafc7e1e7@mail.gmail.com>
Subject: Re: PATCH: 6/6 [3rd try]: Add AVX support (gdbserver changes)
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00117.txt.bz2

On Fri, Apr 2, 2010 at 10:39 AM, Daniel Jacobowitz <dan@codesourcery.com> w=
rote:
> On Tue, Mar 30, 2010 at 09:48:33AM -0700, H.J. Lu wrote:
>> OK to install?
>
> Pretty much OK.
>
>> +#ifdef __x86_64__
>> + =A0if (num_xmm_registers =3D=3D 8)
>> + =A0 =A0init_registers_i386_linux ();
>> + =A0else
>> + =A0 =A0init_registers_amd64_linux ();
>> +#else
>> + =A0init_registers_i386_linux ();
>> +#endif
>
> ...
>
>> + =A0/* Update gdbserver_xmltarget with XML support. =A0*/
>> +#ifdef __x86_64__
>> + =A0if (num_xmm_registers =3D=3D 8)
>> + =A0 =A0gdbserver_xmltarget =3D "i386-linux.xml";
>> + =A0else
>> + =A0 =A0gdbserver_xmltarget =3D "amd64-linux.xml";
>> +#else
>> + =A0gdbserver_xmltarget =3D "i386-linux.xml";
>> +#endif
>
> Isn't the second block redundant with the first block?

You are right. I will remove it.

>> +/* Process qSupported query, "xmlRegisters=3D". =A0Update the buffer si=
ze for
>> + =A0 PTRACE_GETREGSET. =A0*/
>> +
>> +static void
>> +x86_linux_process_qsupported (const char *query)
>> +{
>> + =A0/* Return if gdb doesn't support XML. =A0If gdb sends "xmlRegisters=
=3D"
>> + =A0 =A0 in qSupported query, it supports x86 XML target descriptions. =
=A0*/
>> + =A0use_xml =3D query !=3D NULL && strncmp (query, "xmlRegisters=3D", 1=
3) =3D=3D 0;
>> +
>> + =A0x86_linux_update_xmltarget ();
>> +}
>
> Presumably, the protocol-wise correct thing to do would be to
> search for "xmlRegisters=3D" that had an element "x86".

I will update to check "i386", which will be sent from x86 gdb.

>
> Otherwise OK.

Thanks.

--=20
H.J.