From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A5DA33851C11 for ; Thu, 25 Jun 2020 12:03:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A5DA33851C11 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=ro@cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 771E7A7C4C; Thu, 25 Jun 2020 14:03:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4g3bQwc_ywHo; Thu, 25 Jun 2020 14:03:33 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4fddbb33.dip0.t-ipconnect.de [79.221.187.51]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 76140A7BE2; Thu, 25 Jun 2020 14:03:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1593086613; bh=KHWSwa9LGtlus3NzBAF6y1vSFtNJ6l7TWfmbcoxCu3s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YisnIluPPpKAF8Va52usslaHNYtibQAYzO1aoA/bf5Sp7z0DKTT4WS1uxjrRuF7oM D8XaT/eXQnE3Bf0IuJntUwLA5vnZsz6OaywihODd95+NARZsEP+dJKNMxBdmNuBgut umjd1gcqJj3MWUqQMrxoqJfRMTaPm6yQYAP4NxBuE6RzpMMrdXeE90oeDgCzhUExp9 ez9PnJhVaRZepj+6A67ap1XdbexyajM3Ka3NtBZ5VuQS6oUPEEuyGOYx0g4/NkIaH1 V2x6EE6xKZ7TR9o0Wylb7D0+YZHLj81REBOBsMnPg3y/gelcHOOQOGnWtsWj6Bb8qC EQ24TY9QjDD7w== From: Rainer Orth To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't include *sol2-tdep.o on Linux/sparc* References: <00d11a67-fb37-52de-859d-f8055c841668@simark.ca> <7faf3651-4d93-8609-ddfc-51f2359a822b@redhat.com> Date: Thu, 25 Jun 2020 14:03:31 +0200 In-Reply-To: <7faf3651-4d93-8609-ddfc-51f2359a822b@redhat.com> (Pedro Alves's message of "Thu, 25 Jun 2020 10:57:50 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3790.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 12:03:37 -0000 Hi Pedro, > On 6/25/20 9:23 AM, Rainer Orth wrote: >>> From a quick check, this should just work today: the functions declared >>> in sparc*-sol2-tdep.c are only called in Solaris-specific files already. >>> I'll give it a try separately. sparc{32,64}_sol2_init_abi are currently >>> declared in common files (sparc*-tdep.h), but they can just be made >>> static and the declarations removed. >> the following patch does just that: tested on sparc64-unknown-linux-gnu >> (build only due to PR tdep/26170) and sparcv9-sun-solaris2.11. > > I got curious and looked into git history to find why that was done > in the first place. > > 'git blame configure.tgt' points at a4ce5b0d0204 as the commit that > converted the old .mt files into configure.tgt. > > And then: > > $ git blame a4ce5b0d0204^ -- ./config/sparc/linux64.mt > > points at: > > commit 691342f948aa4f8c4f4e039669276faf753a36b4 > Author: David S. Miller > AuthorDate: Mon Feb 27 06:14:51 2006 +0000 > > 2006-02-26 David S. Miller > > * config/sparc/linux.mt (TDEPFILES): Add sol2-tdep.o. > * config/sparc/linux64.mt (TDEPFILES): Likewise. > > Which is... drumroll... a big nothingburger: > > https://sourceware.org/legacy-ml/gdb-patches/2006-02/msg00492.html > > So, nothing to see here, move along. :-) however, this only accounts for the presence of sol2-tdep.o, not the rest (sparc*-sol2-tdep.o). I looked further and they were present from the beginning when sparc/linux64.mt was introduced. There may have been a reason to include them once but it's certainly gone today. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University