From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id D2DCF38518AF for ; Thu, 17 Nov 2022 09:46:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2DCF38518AF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0CE7DA8538; Thu, 17 Nov 2022 10:46:55 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PE-Osfj8SzXw; Thu, 17 Nov 2022 10:46:54 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855a16.dip0.t-ipconnect.de [80.133.90.22]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 82F63A81F9; Thu, 17 Nov 2022 10:46:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1668678414; bh=cCPleBCiLY45DGeVhVM416LC06QwkiQPD3Ne4bzasPU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TSq4ahpWIqCje10usTjCNE8sLHeB2yJIocg/IbXFNXUd9wvYE6a9rWXJKJqwScScv ry/ENwBboapS4WKPJayC8tnPvm1ZPFxgiK566KgruNqAZBHl/ll27A99bT940x9P/f B3mHdwcAWTHWKcQ/8WiThIqaiVeQ31d6CAErx4qyPFCjaItJDI7AyPncEE9m6H4C1Z Wp984eG/prf6Ucb4zXfPqvbmZjbg28o1FDOmRAdHME/MRfSHYonoa/O5BtVq3AuvM+ +Evftt47UrLdarNu36gklk4ipV8bFfkLrafoUv6iNDn+CF3rWYmWZTkg2nFda6755o rxskzQ7VJfiYw== From: Rainer Orth To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix various procfs.c compilation errors References: Date: Thu, 17 Nov 2022 10:46:54 +0100 In-Reply-To: (Simon Marchi's message of "Wed, 16 Nov 2022 10:53:49 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3788.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, > On 11/16/22 10:02, Rainer Orth wrote: >> procfs.c has accumulated several compilation errors lately (some of them >> new with GCC 12), which are fixed by this patch: >>=20 >> * auxv_parse gets: >>=20 >> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:144:7: error: =E2=80=98int >> procfs_target::auxv_parse(gdb_byte**, gdb_byte*, CORE_ADDR*, CORE_ADDR*)= =E2=80=99 >> marked =E2=80=98override=E2=80=99, but does not override >> 144 | int auxv_parse (gdb_byte **readptr, >> | ^~~~~~~~~~ >>=20 >> Obviouly, procfs.c was missed in the auxv_parse constification. > > Sorry, my bad for this one. no worries while the fixes are as easy as this one. I thought about reviving the old Solaris buildbots with the new buildmaster to catch stuff like this early, but am uncertain: the old buildbods had been compile-only for various reasons, but ISTM that the new ones need to be compile-and-test, and zero-FAIL actually, which is completely unattainable for Solaris right now. Thanks. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University