Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Bernd,

> On 6/4/21 3:39 PM, Tom Tromey wrote:
>>>>>>> "Bernd" == Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
>> 
>> Bernd> I believe it is right to avoid the SIGPIPE before calling the plugin,
>> Bernd> instead of doing that in gcc-trunk, since we don't know which version
>> Bernd> we will be calling, and all versions I tried have failed like this.
>> 
>> That seems fine, but I think it would be better to install the handler
>> just when working with the plugin, and then uninstall it afterward, sort
>> of like what class scoped_ignore_sigttou does.
>> 
>
> Okay, done, that works for me.
>
> Is this OK?

this patch broke the Solaris build:

/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c:659:3: error: ‘sighandler_t’ does not name a type; did you mean ‘sa_handler’?
  659 |   sighandler_t m_osigpipe = NULL;
      |   ^~~~~~~~~~~~
      |   sa_handler
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c: In constructor ‘scoped_ignore_sigpipe::scoped_ignore_sigpipe()’:
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c:644:5: error: ‘m_osigpipe’ was not declared in this scope
  644 |     m_osigpipe = signal (SIGPIPE, SIG_IGN);
      |     ^~~~~~~~~~
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c:644:18: error: ‘signal’ was not declared in this scope; did you mean ‘sigval’?
  644 |     m_osigpipe = signal (SIGPIPE, SIG_IGN);
      |                  ^~~~~~
      |                  sigval
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c: In destructor ‘scoped_ignore_sigpipe::~scoped_ignore_sigpipe()’:
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c:651:22: error: ‘m_osigpipe’ was not declared in this scope
  651 |     signal (SIGPIPE, m_osigpipe);
      |                      ^~~~~~~~~~
/vol/src/gnu/gdb/hg/master/dist/gdb/compile/compile.c:651:5: error: ‘signal’ was not declared in this scope; did you mean ‘sigval’?
  651 |     signal (SIGPIPE, m_osigpipe);
      |     ^~~~~~
      |     sigval

and I have a very hard time deciding where <signal.h> needs to be
included given the enormous range of headers included by compile.c.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University