Hi Simon,

>>> While those patches only/mostly affect Solaris-specific code, I have
>>> some questions:
>>> 
>>> * Two settings above (static_transform_name,
>>>   sofun_address_maybe_missing) only apply to quirks of stabs.
>>> 
>>>   The first is completely Solaris-specific (or rather specific to the
>>>   Studio compilers) and I didn't do any real testing here.  Studio cc
>>>   has deprecated stabs support in the 12.4 release back in 2015, gcc has
>>>   defaulted to DWARF-2 on Solaris 7+ since 2004, so maybe the whole
>>>   static_transform_name code can go?
>>
>> I would be completely fine with it.  The Solaris port pretty much depends on
>> the time you have to give, so if you don't have time to deal with ancient
>> stuff,
>> it's fine to drop support for it.
>
> I guess I'll go for it, time permitting: while it doesn't create a
> burden, it's just dead code these days.

here's the patch: tested on sparcv9-sun-solaris2.11 and
x86_64-pc-linux-gnu with --enable-targets=all (which promptly caught an
error in xcoffread.c).

Ok for master?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2020-06-24  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* sol2-tdep.c (sol2_static_transform_name): Remove.
	(sol2_init_abi): Don't register it.
	* gdbarch.sh (static_transform_name): Remove.
	* gdbarch.c, gdbarch.h: Regenerate.

	* dbxread.c (read_dbx_symtab) <'S'>: Remove call to
	gdbarch_static_transform_name.
	* mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
	* stabsread.c (define_symbol): Remove SunPRO etc. static variable
	encoding.
	(define_symbol) <'S'>: Remove gdbarch_static_transform_name
	handling.
	<'V'>: Likewise.
	* xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
	<'S'>: Remove call to gdbarch_static_transform_name.