From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 561A1384843F for ; Mon, 14 Jun 2021 14:39:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 561A1384843F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 48A8CB4851; Mon, 14 Jun 2021 16:39:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1TCbPOwJHWXq; Mon, 14 Jun 2021 16:39:03 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854661.dip0.t-ipconnect.de [80.133.70.97]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 7D32BB47BF; Mon, 14 Jun 2021 16:39:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1623681543; bh=MRZrTHmhVxWslpIJMrDhBUCgB8XbhyLLIkLWqyoJboI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XHPbMs00jNpJix07FxYZhYf02/0eK/362SzkV1oQhLEX8GuK8VIuW7JteqoulxsQM jQvEZDBvsGAVeTckuWpefuG97bc35BA/y7x9vU6v4KvqSAhWd852FY0j4QZdthFtsx hSg8MsSwS7ocvyFK6j2g5SyLdKHa4DAaqBalfXgtFEyz+NfgAt5G6SLq4qF3fs49lW vFU/xawWKyb7YqTWtD3EfXCnvBIYG8mOQNzaL4drd/pwfEBm63YjOsUAoxIqvRvTJg 3IJuGyFtrwCdu+gLbxkcKobe5IsMHhnnNTyXxf6BQkTifY3/z7EmaW4GYWh32/z3dZ Xi5IFE5Yf424w== From: Rainer Orth To: Bernd Edlinger Cc: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails References: <87tumgp1ob.fsf@tromey.com> <87zgw5oijf.fsf@tromey.com> Date: Mon, 14 Jun 2021 16:39:03 +0200 In-Reply-To: (Bernd Edlinger's message of "Mon, 14 Jun 2021 16:36:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3787.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 14:39:07 -0000 Hi Bernd, > On 6/14/21 2:59 PM, Rainer Orth wrote: >> Hi Bernd, >> >>>> and I have a very hard time deciding where needs to be >>>> included given the enormous range of headers included by compile.c. >>>> >>> >>> Oh, I see, looks like it did only work by chance. >>> Maybe just include it after all other headers: >> >> that's what I've been using myself to fix the build locally. However, >> as I said I'm completely uncertain if that's the right fix, especially >> given that gdb/compile files don't include any system headers directly. >> > > Are you concerned, that it might be unavailable on some platfroms? > > I seems to be included where needed in many gdb source files. > It's not the plain system header anyways, actually it seems to be > a gnulib-enhanced version which tries to improve the portability. no, I'm concerned that including the system header directly doesn't match gdb conventions. Many are only included indirectly via some gdb-private header, but I don't see a clear pattern there. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University