From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 69BB93858C50 for ; Thu, 31 Mar 2022 08:40:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69BB93858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 7DC6ABE90C for ; Thu, 31 Mar 2022 10:40:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JkcwPRPXglBL for ; Thu, 31 Mar 2022 10:40:17 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508554ce.dip0.t-ipconnect.de [80.133.84.206]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 07309BE79E for ; Thu, 31 Mar 2022 10:40:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1648716017; bh=yTzo03sXNF9EwKTOmk2yfJdKlkwS/8Y0ZOYGR5x+LXA=; h=From:To:Subject:Date:From; b=k9AYJlcTIRYsXiMG79Y4jJND5eKKtKZ7KKS4ww4kybqJeaPB6IoLvXvcIOFZ9CaP4 T2FE9SSUIGK6KKmvMYAFBNvdpHbskPYelZTsjeSYDQuzHAmzhq1KDlOa+p0okbLneV FvbaLF0e1UGDfuxs3wkac1ah1irBMrzr5V1dFG7kOu2KLBMtA6jwko3ojyq9LkpzhN y65X2X+JLCiTUfEbVTe9EVDk3WJzwcdFU9/eqk2Ld4qLI+HIvArHn8LLQdF+YlVkYP B54Fnt1jGp0MHwQWUfRnf3F8Rv4dtUmmbB8v6wX2rPUpDW+RxMSeH/2hUIhbBeMVsk 9usaHln4lGJ+A== From: Rainer Orth To: gdb-patches@sourceware.org Subject: [COMMITTED PATCH] Fix procfs.c compilation Date: Thu, 31 Mar 2022 10:40:16 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-3794.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 08:40:20 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable procfs.c doesn't compile on Solaris: /vol/src/gnu/gdb/hg/master/local/gdb/procfs.c: In member function =E2=80=98= virtual bool procfs_target::info_proc(const char*, info_proc_what)=E2=80=99: /vol/src/gnu/gdb/hg/master/local/gdb/procfs.c:3302:3: error: =E2=80=98gdb_a= rgv=E2=80=99 was not declared in this scope 3302 | gdb_argv built_argv (args); | ^~~~~~~~ /vol/src/gnu/gdb/hg/master/local/gdb/procfs.c:3303:20: error: =E2=80=98buil= t_argv=E2=80=99 was not declared in this scope; did you mean =E2=80=98build= argv=E2=80=99? 3303 | for (char *arg : built_argv) | ^~~~~~~~~~ | buildargv Fixed by including "gdbsupport/buildargv.h". Tested on amd64-pc-solaris2.11, sparcv9-sun-solaris2.11. Installed on master and gdb-12 branch to unbreak the build. On master, with -Werror enabled, there's more, but I'm still investigating how to handle that. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=pc.patch diff --git a/gdb/procfs.c b/gdb/procfs.c --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -45,6 +45,7 @@ #include "observable.h" #include "gdbsupport/scoped_fd.h" #include "gdbsupport/pathstuff.h" +#include "gdbsupport/buildargv.h" /* This module provides the interface between GDB and the /proc file system, which is used on many versions of Unix --=-=-=--