From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Remove cleanup from procfs.c
Date: Tue, 04 Sep 2018 10:50:00 -0000 [thread overview]
Message-ID: <yddk1o1y1xw.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20180903190250.11599-3-tom@tromey.com> (Tom Tromey's message of "Mon, 3 Sep 2018 13:02:48 -0600")
Hi Tom,
> This removes the last remaining cleanup from procfs.c, replacing it
> with a unique_ptr specialization.
I've now regtested the patch on amd64-pc-solaris2.11. After fixing one
compile failure
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:275:13: error: ‘void do_destroy_procinfo_cleanup(void*)’ declared ‘static’ but never defined [-Werror=unused-function]
static void do_destroy_procinfo_cleanup (void *);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
by removing the unnecessary declaration, testing passed without
regressions (as far as I can tell with racy tests etc.).
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-09-04 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 19:03 [PATCH 0/4] Some cleanup removal Tom Tromey
2018-09-03 19:02 ` [PATCH 1/4] Remove cleanup from add_path Tom Tromey
2018-09-03 19:03 ` [PATCH 2/4] Remove cleanup from procfs.c Tom Tromey
2018-09-04 10:50 ` Rainer Orth [this message]
2018-09-04 16:56 ` Tom Tromey
2018-09-03 19:03 ` [PATCH 4/4] Remove cleanup from try_open_exec_file Tom Tromey
2018-09-03 19:03 ` [PATCH 3/4] Return std::string from gdb_bfd_errmsg Tom Tromey
2018-09-04 9:37 ` [PATCH 0/4] Some cleanup removal Rainer Orth
2018-09-04 16:58 ` Tom Tromey
2018-09-04 18:30 ` Rainer Orth
2018-09-13 22:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddk1o1y1xw.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).