From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41778 invoked by alias); 9 Nov 2018 22:22:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41763 invoked by uid 89); 9 Nov 2018 22:22:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=replying, Hx-languages-length:1610, lately X-HELO: smtp.CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE (HELO smtp.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Nov 2018 22:22:39 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6F5275CD; Fri, 9 Nov 2018 23:22:36 +0100 (CET) Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8cFkrPlZ0lci; Fri, 9 Nov 2018 23:22:34 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p4FDDBC5E.dip0.t-ipconnect.de [79.221.188.94]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 2E3AA5CC; Fri, 9 Nov 2018 23:22:34 +0100 (CET) From: Rainer Orth To: Simon Marchi Cc: Brian Vandenberg , "brobecker\@adacore.com" , "gdb-patches\@sourceware.org" Subject: Re: [PATCH][PR gdb/8527] Interrupt not functional in Eclipse/CDT on Solaris References: <20181101211949.GB2705@adacore.com> <5e65ba26-c0b6-ab77-a682-933f3bcd1827@ericsson.com> Date: Fri, 09 Nov 2018 22:22:00 -0000 In-Reply-To: <5e65ba26-c0b6-ab77-a682-933f3bcd1827@ericsson.com> (Simon Marchi's message of "Fri, 9 Nov 2018 21:08:37 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00180.txt.bz2 Hi Simon, > On 2018-11-01 5:45 p.m., Brian Vandenberg wrote: >> Greetings, >> >> Did you run the testsuite before and after the patch, by any chance? >> >> >> Nope. In my work environment I don't have much flexibility on >> getting/installing software. If I run the test suite I would probably have >> to setup an IllumOS VM at home to run it, but that'd be x86 not SPARC. >> >> >> For multiline comments like the above, we do not repeat the '*' >>> at the beginning of each line. >>> /* PR gdb/8527: Was not correctly interrupting the inferior process >>> when ^C was pressed in the debug terminal. */ >>> And if I may, reading this sentence, it's a bit hard to understand >>> what the comment is trying to explain. The following might be >>> a little more precise: >>> /* PR gdb/8527: Call set_sigint_trap to make sure that a ctrl-c >>> pressed in the debugger terminal gets passed down to the >>> inferior, thus causing it to be interrupted. */ >> >> >> I've no qualms with those changes. Thanks for your feedback. > > Asking because it's ambiguous... do you plan on sending an updated patch? I don't think this is necessary: I'm going to take care of that. > As for the patch content and its testing, perhaps Rainer can give some feedback. Sorry for the delay in replying: I've both been very busy with end-of-stage1 gcc stuff and unwell lately. I hope to get to this soon. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University