From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 0C69939730C1 for ; Thu, 17 Nov 2022 09:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C69939730C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 1F955A8149; Thu, 17 Nov 2022 10:50:12 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVjzAWBfeXYF; Thu, 17 Nov 2022 10:50:11 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855a16.dip0.t-ipconnect.de [80.133.90.22]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id B76E2A8371; Thu, 17 Nov 2022 10:50:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1668678611; bh=uu7DkjDzukM+H1EljIBwVIbCJtQdM0+gBwQDREdQbcY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Dn71H5NQnp9EsFY1Df+4Oy7frMabAI2D8KrhZQs1+r17XJavuvJsnv/S41gKwkpGY 6X3b1QH4r90z2ZSSSYl53tMpJO6FPxOA+ipZP7402kLwjhWdi37FtbPDIht4q7D7kh wY8i0ueqNBjtr9u2aokmjz4OuEszNjsRdC6tYWm616zAQ/A9orwyTD/k914xeHwTsc touS/FTwcA1/PfO54D8uedUjZ2TJpe+ZJCq+9ur4yswRAO8swqsGttw/NCJD3x+QtN QJLawQKOmiWwKtaiV3pBFcXa4xjCR8990n8SkGlRIi/M1rhzBZZQsASzqrCCX7UgQM NVT3GISPfYZEw== From: Rainer Orth To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix various procfs.c compilation errors References: <65dc9aec-b868-5988-e9b5-5f460d38f6d2@arm.com> Date: Thu, 17 Nov 2022 10:50:11 +0100 In-Reply-To: <65dc9aec-b868-5988-e9b5-5f460d38f6d2@arm.com> (Luis Machado's message of "Wed, 16 Nov 2022 19:04:55 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3788.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_ASCII_DIVIDERS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Luis, >> * find_memory_regions_callback fails with >> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In function =E2=80=98int >> find_memory_regions_callback(prmap*, find_memory_region_ftype, void*)=E2= =80=99: >> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3167:18: error: too few arg= uments to function >> 3167 | return (*func) ((CORE_ADDR) map->pr_vaddr, >> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 3168 | map->pr_size, >> | ~~~~~~~~~~~~~ >> 3169 | (map->pr_mflags & MA_READ) !=3D 0, >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 3170 | (map->pr_mflags & MA_WRITE) !=3D 0, >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 3171 | (map->pr_mflags & MA_EXEC) !=3D 0, >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 3172 | 1, /* MODIFIED is unknown, pass it as true. = */ >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~ >> 3173 | data); >> | ~~~~~ >> Again, procfs.c was overlooked when adding the new memory_tagged arg. >> Unfortunately, it wasn't even documented in gdb/defs.h when it was >> added in >>=20 > > Sorry, that was an oversight. I failed to updated all the hooks. I think > there was a BSD one that got fixed after the following commit was pushed. no problem: the primary issue was finding/understanding what the new arg meant/needs to be here. Could you take care of updating the defs.h comment to avoid such confusion in the future? Thanks. Rainer --=20 ---------------------------------------------------------------------------= -- Rainer Orth, Center for Biotechnology, Bielefeld University