public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] dwarf2read.c (peek_die_abbrev): Improve error message text.
@ 2014-11-26 22:54 Doug Evans
  2014-12-03  2:37 ` Doug Evans
  0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2014-11-26 22:54 UTC (permalink / raw)
  To: gdb-patches

Hi.

This patch improves the text of an error message.
I happened to trip over this, and it was useful
to know the bogus CU from the error text.

2014-11-26  Doug Evans  <dje@google.com>

	* dwarf2read.c (peek_die_abbrev): Improve error message text.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 36cbbd9..5526db3 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -7130,8 +7130,10 @@ peek_die_abbrev (const gdb_byte *info_ptr, unsigned int *bytes_read,
   abbrev = abbrev_table_lookup_abbrev (cu->abbrev_table, abbrev_number);
   if (!abbrev)
     {
-      error (_("Dwarf Error: Could not find abbrev number %d [in module %s]"),
-	     abbrev_number, bfd_get_filename (abfd));
+      error (_("Dwarf Error: Could not find abbrev number %d in %s"
+	       " at offset 0x%x [in module %s]"),
+	     abbrev_number, cu->per_cu->is_debug_types ? "TU" : "CU",
+	     cu->header.offset.sect_off, bfd_get_filename (abfd));
     }
 
   return abbrev;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dwarf2read.c (peek_die_abbrev): Improve error message text.
  2014-11-26 22:54 [PATCH] dwarf2read.c (peek_die_abbrev): Improve error message text Doug Evans
@ 2014-12-03  2:37 ` Doug Evans
  0 siblings, 0 replies; 2+ messages in thread
From: Doug Evans @ 2014-12-03  2:37 UTC (permalink / raw)
  To: gdb-patches

Doug Evans writes:
 > Hi.
 > 
 > This patch improves the text of an error message.
 > I happened to trip over this, and it was useful
 > to know the bogus CU from the error text.
 > 
 > 2014-11-26  Doug Evans  <dje@google.com>
 > 
 > 	* dwarf2read.c (peek_die_abbrev): Improve error message text.

Committed.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-03  2:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26 22:54 [PATCH] dwarf2read.c (peek_die_abbrev): Improve error message text Doug Evans
2014-12-03  2:37 ` Doug Evans

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).