public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: George Barrett <bob@bob131.so>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] guile: stop procedures on invalid breakpoints
Date: Fri, 21 May 2021 00:52:33 +1000	[thread overview]
Message-ID: <zgs_i_ro9onef4ydybhjfk0-jgxdr1_w5zvj3ek.xbx/q7iyx9g3@mail.bob131.so> (raw)
In-Reply-To: <20210520103257.GB2672@embecosm.com>

On Thu, May 20, 2021 at 11:32:57AM +0100, Andrew Burgess wrote:
> Thanks for doing this.

No worries. Thanks for having a look.

> The { ... } should be removed for single statement blocks.

Ack.

> I guess it's just me, but I'd prefer to see the 'bp_smob->bp != NULL'
> factored out of these two checks like:
> 
>   if (bp_smob->bp != nullptr)
>     {
>       if (bp_smob->bp->cond_string != nullptr)
>         ...
>       if (extlang == nullptr)
>         ...
>     }
> 
> though this is not a requirement, if you feel strongly that your way
> is better then that's fine.

Not at all, ack.

> But I think you should s/NULL/nullptr/ on these lines (and given there
> are only 2 other uses of NULL in this function, maybe replace them
> too?)

Ack.

> Otherwise, this looks great.
> 
> Thanks,
> Andrew

I might wait until the doc review before rolling a v2, to reduce the amount of
spam ;)

Thanks

  reply	other threads:[~2021-05-20 14:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 23:28 George Barrett
2021-05-20 10:32 ` Andrew Burgess
2021-05-20 14:52   ` George Barrett [this message]
2021-06-08 19:59 ` [PING] " George Barrett
2021-06-09 11:43   ` Eli Zaretskii
2021-06-09 13:51     ` George Barrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=zgs_i_ro9onef4ydybhjfk0-jgxdr1_w5zvj3ek.xbx/q7iyx9g3@mail.bob131.so \
    --to=bob@bob131.so \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).