Re: build/2490: make[2]: *** [solib-pa64.o] Error 1

Re: build/2490: make[2]: *** [solib-pa64.o] Error 1

[Ulrich Weigand]

The following reply was made to PR build/2490; it has been noted by GNATS.

From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: dave.anglin@nrc-cnrc.gc.ca
Cc: gdb-gnats@sources.redhat.com
Subject: Re: build/2490: make[2]: *** [solib-pa64.o] Error 1
Date: Mon, 4 Aug 2008 19:01:29 +0200

 dave.anglin@nrc-cnrc.gc.ca wrote on 08/04/2008 12:50:32 AM:
 
 > The change to using HAVE_ELF_HP_H doesn't work as it
 > is also defined when doing a native 32-bit SOM build.
 > As I understand it, PA_SOM_ONLY was only defined when
 > doing a native SOM build.
 
 Sorry for the breakage.  I had assumed the header check
 would be sufficient ...
 
 The proposed fix:
  -#ifdef HAVE_ELF_HP_H
  +#if defined(HAVE_ELF_HP_H) && defined(__LP64__)
 
 looks good to me.  Can you send the patch to the
 gdb-patches mailing list?
 
 
 Mit freundlichen Gruessen / Best Regards
 
 Ulrich Weigand
 

Re: build/2490: make[2]: *** [solib-pa64.o] Error 1

[John David Anglin]

The following reply was made to PR build/2490; it has been noted by GNATS.

From: John David Anglin <dave@hiauly1.hia.nrc.ca>
To: gdb-gnats@sources.redhat.com, nobody@sources.redhat.com
Cc: dave.anglin@nrc-cnrc.gc.ca
Subject: Re: build/2490: make[2]: *** [solib-pa64.o] Error 1
Date: Sun, 3 Aug 2008 21:05:20 -0400

 --envbJBWh7q8WU6mo
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 The attached simple fix appears to resolve the problem.
 
 Dave
 -- 
 J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
 National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
 
 --envbJBWh7q8WU6mo
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="solib-pa64.c.d"
 
 Index: solib-pa64.c
 ===================================================================
 RCS file: /cvs/src/src/gdb/solib-pa64.c,v
 retrieving revision 1.10
 diff -u -3 -p -r1.10 solib-pa64.c
 --- solib-pa64.c	1 Jan 2008 22:53:13 -0000	1.10
 +++ solib-pa64.c	4 Aug 2008 00:38:43 -0000
 @@ -46,7 +46,7 @@
  
  /* We can build this file only when running natively on 64-bit HP/UX.
     We check for that by checking for the elf_hp.h header file.  */
 -#ifdef HAVE_ELF_HP_H
 +#if defined(HAVE_ELF_HP_H) && defined(__LP64__)
  
  /* FIXME: kettenis/20041213: These includes should be eliminated.  */
  #include <dlfcn.h>
 
 --envbJBWh7q8WU6mo--

build/2490: make[2]: *** [solib-pa64.o] Error 1

[dave.anglin]

>Number:         2490
>Category:       build
>Synopsis:       make[2]: *** [solib-pa64.o] Error 1
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 03 22:58:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Dave Anglin
>Release:        gdb-6.8
>Organization:
>Environment:
hppa2.0w-hp-hpux11.11
>Description:
Building 32-bit version of gdb for hppa2.0w-hp-hpux11.11
fails:

gcc -c -g -O2   -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/opt/g
nu/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src
/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -
I../libdecnumber -I../../src/gdb/../libdecnumber   -DMI_OUT=1 -DTUI=1  -Wall -Wd
eclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign
 -Wno-unused -Wno-switch -Wno-char-subscripts -Werror ../../src/gdb/solib-pa64.c
cc1: warnings being treated as errors
../../src/gdb/solib-pa64.c: In function 'read_dld_descriptor':
../../src/gdb/solib-pa64.c:170: warning: passing argument 4 of 'dlgetmodinfo' fr
om incompatible pointer type
../../src/gdb/solib-pa64.c: In function 'pa64_current_sos':
../../src/gdb/solib-pa64.c:472: warning: passing argument 4 of 'dlgetmodinfo' fr
om incompatible pointer type
../../src/gdb/solib-pa64.c:479: warning: passing argument 3 of 'dlgetname' from 
incompatible pointer type
../../src/gdb/solib-pa64.c: In function 'pa64_open_symbol_file_object':
../../src/gdb/solib-pa64.c:539: warning: passing argument 4 of 'dlgetmodinfo' fr
om incompatible pointer type
../../src/gdb/solib-pa64.c:545: warning: passing argument 3 of 'dlgetname' from 
incompatible pointer type
make[2]: *** [solib-pa64.o] Error 1

This appears to have been introduced by the following
change:

2007-10-24  Ulrich Weigand  <uweigand@de.ibm.com>

        * configure.tgt: Remove hppa*64*-*-hpux11* special case.
        * config/pa/hppa64.mt: Delete file.
        * config/pa/hppahpux.mt (MT_CFLAGS): Remove.
        (TDEPFILES): Move somread.o to ...
        * config/pa/hpux.mh (NATDEPFILES): ... here.

        * configure.ac: Add check for elf_hp.h header.
        Search libdl and libxpdl for dlgetmodinfo.
        * config.in, configure: Regenerate.
        * solib-pa64.c: Conditionalize compilation on #ifdef HAVE_ELF_HP_H
        instead of #ifndef PA_SOM_ONLY.  Include "solib.h".
        (pa64_solib_select): Take gdbarch instead of tdep argument.  Call
        set_solib_ops instead of modifying current_target_so_ops.
        * solib-pa64.h (pa64_solib_select): Update prototype.
        * solib-som.c: Remove include of "som.h".  Include "solib.h".
        (som_solib_select): Take gdbarch instead of tdep argument.  Call
        set_solib_ops instead of modifying current_target_so_ops.
        * solib-som.h (som_solib_select): Update prototype.
        * hppa-hpux-tdep.c (hppa_hpux_som_init_abi): Pass gdbarch instead
        of tdep to som_solib_select call.
        (hppa_hpux_elf_init_abi): Pass gdbarch instead of tdep to
        * Makefile.in: Update dependencies.

The change to using HAVE_ELF_HP_H doesn't work as it
is also defined when doing a native 32-bit SOM build.
As I understand it, PA_SOM_ONLY was only defined when
doing a native SOM build.

Possibly, the errors can be fixed.
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: