From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28162 invoked by alias); 2 Dec 2008 17:28:02 -0000 Received: (qmail 28138 invoked by uid 71); 2 Dec 2008 17:28:01 -0000 Date: Tue, 02 Dec 2008 17:28:00 -0000 Message-ID: <20081202172801.28137.qmail@sourceware.org> To: nobody@sources.redhat.com Cc: gdb-prs@sources.redhat.com, From: "Richard Stuckey" Subject: RE: remote/2560: valid reponse packet can be treated as 'ENN'error packet Reply-To: "Richard Stuckey" Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00063.txt.bz2 The following reply was made to PR remote/2560; it has been noted by GNATS. From: "Richard Stuckey" To: "Daniel Jacobowitz" Cc: Subject: RE: remote/2560: valid reponse packet can be treated as 'ENN'error packet Date: Tue, 2 Dec 2008 17:22:38 -0000 Yes, it was getting a register frame: the first hex digit for the first register was 'E' ! Good idea about the lowercase. Thanks -----Original Message----- From: Daniel Jacobowitz [mailto:drow@false.org]=20 Sent: 02 December 2008 17:19 To: Richard Stuckey Cc: gdb-gnats@sources.redhat.com Subject: Re: remote/2560: valid reponse packet can be treated as 'ENN'error packet On Tue, Dec 02, 2008 at 05:04:33PM -0000, richard.stuckey@arc.com wrote: > This test is too weak: if the response packet contains valid data which happens to begin with an 'E' then it will be incorrectly treated as an error. remote_send is only used in four cases: p/P and g/G. If you encountered it in one of those, I suggest sending back lowercase hex rather than uppercase hex. That does not invalidate your correct report; merely a suggestion. --=20 Daniel Jacobowitz CodeSourcery