[Bug sim/9734] New: result of sim_create_sim not checked in remote-sim.c

[Bug sim/9734] New: result of sim_create_sim not checked in remote-sim.c

[richard dot stuckey at arc dot com]

If sim_create_inferior fails to create the inferior, for whatever reason, gdb
should not mark the target as running.

The code at the end of function gdbsim_create_inferior in remote-sim.c should be
changed to:

  if (sim_create_inferior (gdbsim_desc, exec_bfd, argv, env) == SIM_RC_OK)
    {
      inferior_ptid = pid_to_ptid (42);
      target_mark_running (&gdbsim_ops);
      insert_breakpoints ();    /* Needed to get correct instruction in cache */

      clear_proceed_status ();
    }

-- 
           Summary: result of sim_create_sim not checked in remote-sim.c
           Product: gdb
           Version: 6.8
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: sim
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: richard dot stuckey at arc dot com
                CC: gdb-prs at sourceware dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=9734

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[richard dot stuckey at arc dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|result of sim_create_sim not|result of
                   |checked in remote-sim.c     |sim_create_inferior not
                   |                            |checked in remote-sim.c


http://sourceware.org/bugzilla/show_bug.cgi?id=9734

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[pedro at codesourcery dot com]

------- Additional Comments From pedro at codesourcery dot com  2009-01-12 14:33 -------
I see that the result of sim_create_inferior is still not checked on current
mainline.  I think that it would be best to throw an error() instead, otherwise
currently core gdb will probably assert, in thinking the inferior was created.

if (sim_create_inferior (gdbsim_desc, exec_bfd, argv, env) != SIM_RC_OK)
  error (_("foo failed to create, blah!"));


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1


http://sourceware.org/bugzilla/show_bug.cgi?id=9734

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[richard dot stuckey at arc dot com]

------- Additional Comments From richard dot stuckey at arc dot com  2009-01-12 14:48 -------
I have added a check to the ARC-specific version of sim_create_inferior that the
endianness of the executable file matches the endiannness of the simulator
target, for the situation that the target instance is created before the
executable file has been specified (this check should also probably go into the
gdb core code, in remote-sim.c, but I try to avoid altering the core code where
possible); if the check fails, the function gives a warning and returns 
SIM_RC_FAIL.

This, together with the change I suggested to gdbsim_create_inferior, gives the
behaviour:

(gdb) set endian big
The target is assumed to be big endian
(gdb) target sim
Connected to the simulator.
(gdb) file test.little
Reading symbols from test.little...done.
(gdb) load
(gdb) run
Starting program: test.little 
Target is big-endian but executable file test.little is little-endian.
The program is not being run.

gdb appears to be left in a stable state at this point, but I have not carried
out extensive testing on this, so am willing to accept that throwing an error
may be better.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9734

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[vapier at gentoo dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=9734

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vapier at gentoo dot org

--- Comment #3 from Mike Frysinger <vapier at gentoo dot org> 2012-02-16 04:42:16 UTC ---
i tested over here and indeed, the code path suggested in the summary results
in gdb attempting to dump core.  i'll post a patch to use error().

$ ./gdb/gdb /tftpboot/u-boot
(gdb) target sim
Connected to the simulator.
(gdb) load
Loading section .text.pre, size 0xf0 lma 0x3f00000
Loading section .text.init, size 0x170 lma 0x3f000f0
Loading section .text, size 0x2af90 lma 0x3f00260
Loading section .rodata, size 0x12d04 lma 0x3f2b1f0
Loading section .data, size 0xa524 lma 0x3f3def4
Loading section .u_boot_cmd, size 0x8a4 lma 0x3f48418
Loading section .text_l1, size 0x28 lma 0x3f48cbc
Start address 0x3f00000
Transfer rate: 2385696 bits in <1 sec.
(gdb) run
Starting program: /tftpboot/u-boot 
thread.c:72: internal-error: inferior_thread: Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n) y
thread.c:72: internal-error: inferior_thread: Assertion `tp' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Create a core file of GDB? (y or n) y
Aborted (core dumped)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[vapier at gentoo dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=9734

--- Comment #4 from Mike Frysinger <vapier at gentoo dot org> 2012-02-16 04:54:55 UTC ---
patch posted here:
 http://sourceware.org/ml/gdb-patches/2012-02/msg00317.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug sim/9734] result of sim_create_inferior not checked in remote-sim.c

[vapier at gentoo dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=9734

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Mike Frysinger <vapier at gentoo dot org> 2012-02-16 18:30:46 UTC ---
committed aforementioned patch

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.