[Bug c++/9729] New: incorrect 'unmatched single quote' error

[Bug c++/9729] New: incorrect 'unmatched single quote' error

[pogonyshev at gmx dot net]

This error is clearly wrong:

(gdb) disassemble 'foo(int const*)'
Unmatched single quote.

Test program is attached.  The default value seems to be essential.

-- 
           Summary: incorrect 'unmatched single quote' error
           Product: gdb
           Version: 6.8
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: pogonyshev at gmx dot net
                CC: gdb-prs at sourceware dot org
 GCC build triplet: i486-linux-gnu
  GCC host triplet: i486-linux-gnu
GCC target triplet: i486-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[pogonyshev at gmx dot net]

------- Additional Comments From pogonyshev at gmx dot net  2009-01-11 23:16 -------
Created an attachment (id=3653)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3653&action=view)
test program


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[tromey at redhat dot com]

------- Additional Comments From tromey at redhat dot com  2009-01-12 15:37 -------
You are running afoul of disassemble's command line parsing.
It looks for a space and, if one is found, splits the command
into two arguments at that point.  It does not consider quoting.

I'm inclined to consider this a bug in disassemble, given that
what you are trying to do seems reasonable.
Offhand I am not sure how best to fix this, though.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-01-12 15:37:49
               date|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[pogonyshev at gmx dot net]

------- Additional Comments From pogonyshev at gmx dot net  2009-01-12 17:12 -------
Well, given that 'break' works fine, isn't it simple to just reuse break's parsing?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[tromey at redhat dot com]

------- Additional Comments From tromey at redhat dot com  2009-01-12 22:17 -------
Unfortunately, no.  This sort of parsing in gdb is a mess.
There is no consistency, and each command is free to do as it likes.

In the case of break, there are even hacks in the various 
language-specific expression parsers so that "if" is recognized
as a special terminator.  So, it can't be directly used for disassemble.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[tromey at redhat dot com]

------- Additional Comments From tromey at redhat dot com  2010-01-18 21:51 -------
This bug was fixed as a side effect of this patch:

2009-11-23  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* cli/cli-cmds.c (disassemble_command): Split on comma.
	(init_cli_cmds): Update help.
	* NEWS: Mention incompatible change to 'disassemble'.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|6.8                         |7.1


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c++/9729] incorrect 'unmatched single quote' error

[ppluzhnikov at google dot com]

------- Additional Comments From ppluzhnikov at google dot com  2010-01-18 23:38 -------
(In reply to comment #5)
> This bug was fixed as a side effect of this patch:

It wasn't fixed as a side effect.
It was fixed as the fix for that exact issue (rediscovered)  :-)


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9729

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.