[Bug python/10682] New: gdb.backtrace doesn't handle reloading well

[Bug python/10682] New: gdb.backtrace doesn't handle reloading well

[jason dot orendorff at gmail dot com]

First, if push_frame_filter is called more than once, create_frame_filter dies.
The lambda created in push_frame_filter calls itself recursively.

Second, and more seriously, the gdb.backtrace.push_frame_filter API is not
really suitable to be called by a Python extension at import time. It's
effectful and non-idempotent.

I hit both problems the first time I tried reload()ing a module that registers a
frame filter. :-|

It will be hard to fix without changing the API. The (untested) attachment
attempts one gruesome hack, but I hope you can take a breaking API change instead.

-- 
           Summary: gdb.backtrace doesn't handle reloading well
           Product: gdb
           Version: archer
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: jason dot orendorff at gmail dot com
                CC: gdb-prs at sourceware dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10682] gdb.backtrace doesn't handle reloading well

[jason dot orendorff at gmail dot com]

------- Additional Comments From jason dot orendorff at gmail dot com  2009-09-21 22:15 -------
Created an attachment (id=4220)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4220&action=view)
horrible fix


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10682] gdb.backtrace doesn't handle reloading well

[tromey at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-09-23 22:13:42
               date|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10682] gdb.backtrace doesn't handle reloading well

[tromey at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10682] gdb.backtrace doesn't handle reloading well

[tromey at redhat dot com]

------- Additional Comments From tromey at redhat dot com  2009-09-23 22:15 -------
Created an attachment (id=4225)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4225&action=view)
another patch

Could you try this patch?
It is very similar.  I made the name an explicit argument,
and ensured the ordering remains stable.
What do you think?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10682] gdb.backtrace doesn't handle reloading well

[pmuldoon at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=10682

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.