[Bug python/10806] New: Use ensure_python_env over PyGilState_Ensure

[Bug python/10806] New: Use ensure_python_env over PyGilState_Ensure

[pmuldoon at redhat dot com]

Daniel Jacobowitz wrote about some Python/GDB experiences and bugs in the email:

http://sourceware.org/ml/archer/2009-q4/msg00008.html

This bug (and others in their own bugs) is extracted from that email to track
the issue:

* The archer branch calls PyGILState_Ensure in several places where it
should call ensure_python_env.  So python_language was often unset if
I tried 'gdb -ex "source -p file.py"'.  To work around it, I had the
end of file.py register a new gdb.Command, and called the command.

-- 
           Summary: Use ensure_python_env over PyGilState_Ensure
           Product: gdb
           Version: archer
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned at sourceware dot org
        ReportedBy: pmuldoon at redhat dot com
                CC: gdb-prs at sourceware dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=10806

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10806] Use ensure_python_env over PyGilState_Ensure

[drow at sources dot redhat dot com]

------- Additional Comments From drow at sources dot redhat dot com  2009-10-19 13:18 -------
This causes a segfault when it triggers.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drow at sources dot redhat
                   |                            |dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10806

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10806] Use ensure_python_env over PyGilState_Ensure

[pmuldoon at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sourceware dot|pmuldoon at redhat dot com
                   |org                         |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1


http://sourceware.org/bugzilla/show_bug.cgi?id=10806

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug python/10806] Use ensure_python_env over PyGilState_Ensure

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2009-10-23 13:52 -------
I've checked in a patch to archer-tromey-python. Checked FSF upstream and there
do not appear to be any other areas where PyGILState_Ensure is used. 

commit d4a1bd50bb1d7c3cab75f690597c64191b2b6f78
Author: Phil Muldoon <pmuldoon@redhat.com>
Date:   Thu Oct 22 08:39:28 2009 +0100

    Use ensure_python_dev over PyGILState_Ensure/Release.
    
        2009-10-21  Phil Muldoon <pmuldoon@redhat.com>
    
            PR python/10806
    
            * python/python.c (run_python_script): Use ensure_python_env over
            PyGILState_Ensure.
            (gdbpy_run_events): Likewise.
            (run_python_script): Likewise.
            (source_python_script): Likewise.
            * python/py-breakpoint.c (gdbpy_breakpoint_created): Likewise.
            (gdbpy_breakpoint_deleted): Likewise.
            * python/py-inferior.c (delete_inferior_object): Likewise.
            (add_thread_objet): Likewise.
            (delete_thread_object): Likewise.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10806

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.