From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17784 invoked by alias); 6 Aug 2010 13:31:27 -0000 Received: (qmail 17769 invoked by uid 48); 6 Aug 2010 13:31:27 -0000 Date: Fri, 06 Aug 2010 13:31:00 -0000 Message-ID: <20100806133127.17768.qmail@sourceware.org> From: "pedro at codesourcery dot com" To: gdb-prs@sourceware.org In-Reply-To: <20100726093712.11842.jan.kratochvil@redhat.com> References: <20100726093712.11842.jan.kratochvil@redhat.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug gdb/11842] compat_siginfo_from_siginfo and siginfo_from_compat_siginfo are wrong X-Bugzilla-Reason: CC Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org X-SW-Source: 2010-q3/txt/msg00179.txt.bz2 ------- Additional Comments From pedro at codesourcery dot com 2010-08-06 13:31 ------- Yeah, though in practice si_addr ends up at the same address as si_pid to it is already copied. Note that that's driver code. Who's to say what random drivers do? I'm thinking that we only need to be as thorough/good as arch/x86/ia32/ia32_signal.c:{copy_siginfo_to_user32,copy_siginfo_from_user32}, and that also has a catch-all si_code < 0 branch. (I see that in our version, the "to->si_code == SI_TIMER" branch is unreacheable, as SI_TIMER is < 0. whoops.) -- http://sourceware.org/bugzilla/show_bug.cgi?id=11842 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.