[Bug symtab/11942] New: Duplicate type_hash when reloading debug info of dwarf4 signatured types.

[Bug symtab/11942] New: Duplicate type_hash when reloading debug info of dwarf4 signatured types.

[dje at google dot com]

gdb version: 

When reloading debug information (e.g. because the info got freed due to max-
cache-age), gdb can create a second type_hash table for a signatured type CU, 
and not reuse an existing table.

This can be seen with the following patch:


diff -u -p -r1.439 dwarf2read.c
--- dwarf2read.c        20 Aug 2010 17:16:44 -0000      1.439
+++ dwarf2read.c        23 Aug 2010 21:12:13 -0000
@@ -14203,6 +14203,7 @@ set_die_type (struct die_info *die, stru
   if (cu->type_hash == NULL)
     {
       gdb_assert (cu->per_cu != NULL);
+      gdb_assert (cu->per_cu->type_hash == NULL);
       cu->per_cu->type_hash
        = htab_create_alloc_ex (cu->header.length / 24,
                                offset_and_type_hash,

-- 
           Summary: Duplicate type_hash when reloading debug info of dwarf4
                    signatured types.
           Product: gdb
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: symtab
        AssignedTo: dje at google dot com
        ReportedBy: dje at google dot com
                CC: gdb-prs at sourceware dot org
  GCC host triplet: amd64-linux


http://sourceware.org/bugzilla/show_bug.cgi?id=11942

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug symtab/11942] Duplicate type_hash when reloading debug info of dwarf4 signatured types.

[dje at google dot com]

------- Additional Comments From dje at google dot com  2010-08-23 21:19 -------
Created an attachment (id=4948)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4948&action=view)
test case


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11942

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug symtab/11942] Duplicate type_hash when reloading debug info of dwarf4 signatured types.

[dje at google dot com]

------- Additional Comments From dje at google dot com  2010-08-23 21:20 -------
Forgot to enter gdb version. 7.2.50.20100823-cvs


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11942

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug symtab/11942] Duplicate type_hash when reloading debug info of dwarf4 signatured types.

[dje at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11942

dje at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2010-08-25 00:09:39 UTC ---
Subject: Bug 11942

CVSROOT:	/cvs/src
Module name:	src
Changes by:	devans@sourceware.org	2010-08-25 00:09:14

Modified files:
	gdb            : ChangeLog dwarf2read.c 
	gdb/testsuite  : ChangeLog 
Added files:
	gdb/testsuite/gdb.dwarf2: dw4-sig-types-b.cc dw4-sig-types.cc 
	                          dw4-sig-types.exp dw4-sig-types.h 

Log message:
	PR symtab/11942
	* dwarf2read.c (dwarf2_per_objfile): New members debug_info_type_hash,
	debug_types_type_hash.
	(dwarf2_cu, dwarf2_per_cu_data): Delete member type_hash.
	All uses updated.
	(lookup_die_type): Renamed from tag_type_to_tag.  First look in
	appropriate type_hash table.  All callers updated.
	(allocate_signatured_type_table): Renamed from
	allocate_signatured_type_hash_table.  All callers updated.
	(create_signatured_type_table_from_index): Renamed from
	create_signatured_type_hash_from_index.  All callers updated.
	(read_die_type): Add comment.  Move actual reading to ...
	(read_die_type_1): ... here.  New function.
	(follow_die_ref_or_sig): Tweak comment.
	(set_die_type): Rewrite to use appropriate choice of
	debug_info_type_hash or debug_types_type_hash.
	(get_die_type_at_offset): New function.
	(get_die_type): Call it.
	
	testsuite/
	PR symtab/11942
	* gdb.dwarf2/dw4-sig-types.cc: New file.
	* gdb.dwarf2/dw4-sig-types.h: New file.
	* gdb.dwarf2/dw4-sig-types-b.cc: New file.
	* gdb.dwarf2/dw4-sig-types.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.12114&r2=1.12115
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&r1=1.441&r2=1.442
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.2428&r2=1.2429
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw4-sig-types-b.cc.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw4-sig-types.cc.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw4-sig-types.exp.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw4-sig-types.h.diff?cvsroot=src&r1=NONE&r2=1.1



--- Comment #4 from dje at google dot com 2012-05-02 00:37:47 UTC ---
Fixed in referenced patch.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.