[Bug corefiles/12071] Regression: just a core file started to ask on quit

[Bug corefiles/12071] Regression: just a core file started to ask on quit

[jan dot kratochvil at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1


http://sourceware.org/bugzilla/show_bug.cgi?id=12071

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug corefiles/12071] New: Regression: just a core file started to ask on quit

[jan dot kratochvil at redhat dot com]

./gdb -nx -c core -ex q
->
A debugging session is active.

	Inferior 1 [process 27943] will be killed.

Quit anyway? (y or n) _


This is a regression against FSF GDB 7.2.

aa2614659d7863f1afe4da2251312f7da9236ea5 is the first bad commit
commit aa2614659d7863f1afe4da2251312f7da9236ea5
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Mon Jul 19 17:51:22 2010 +0000

    gdb/
    	Make core files the process_stratum.
    	* corefile.c (core_target): New variable.
    	(core_file_command): Remove variable t, use core_target.
    	* corelow.c (core_ops): Make it static.
    	(init_core_ops): Change to process_stratum.  Initialize CORE_TARGET.
    	* defs.h (make_cleanup_unpush_target): New prototype.
    	* gdbarch.h: Regenerate.
    	* gdbarch.sh (core_pid_to_str): Remove core_stratum from its comment.
    	* gdbcore.h (core_target): New declaration.
    	* inf-ptrace.c (inf_ptrace_create_inferior, inf_ptrace_attach): New
    	variables ops_already_pushed and back_to.  Use push_target,
    	make_cleanup_unpush_target and discard_cleanups calls.
    	* record.c (record_open): Replace core_stratum by a core_bfd check.
    	* target.c (target_is_pushed): New function.
    	(find_core_target): Remove.
    	* target.h (enum strata) <core_stratum>: Remove.
    	(target_is_pushed): New declaration.
    	(find_core_target): Remove declaration.
    	* tracepoint.c (init_tfile_ops) <to_stratum>: Remove comment.
    	* utils.c (do_unpush_target, make_cleanup_unpush_target): New functions.
    
    gdb/doc/
    	Make core files the process_stratum.
    	* gdb.texinfo (Active Targets): Remove core_stratum.  Include
    	record_stratum example.
    
    gdb/testsuite/
    	Make core files the process_stratum.
    	* gdb.base/corefile.exp (run: load core again)
    	(run: sanity check we see the core file, run: with core)
    	(run: core file is cleared, attach: load core again)
    	(attach: sanity check we see the core file, attach: with core)
    	(attach: core file is cleared): New tests.
    	* gdb.base/coremaker.c (main): New parameters.  Implement "sleep" argv.

-- 
           Summary: Regression: just a core file started to ask on quit
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: corefiles
        AssignedTo: jan dot kratochvil at redhat dot com
        ReportedBy: jan dot kratochvil at redhat dot com
                CC: gdb-prs at sourceware dot org
GCC target triplet: x86_64-unknown-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=12071

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug corefiles/12071] Regression: just a core file started to ask on quit

[pedro at codesourcery dot com]

------- Additional Comments From pedro at codesourcery dot com  2010-09-29 09:02 -------
Yeah, the problem is that this no longer works since that patch:

int
have_live_inferiors (void)
{
  struct target_ops *t;

  /* The check on stratum suffices, as GDB doesn't currently support
     multiple target interfaces.  */
  if (have_inferiors ())
    for (t = current_target.beneath; t != NULL; t = t->beneath)
      if (t->to_stratum == process_stratum)
	return 1;

  return 0;
}

since cores are process_stratum now.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=12071

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug corefiles/12071] Regression: just a core file started to ask on quit

[jan dot kratochvil at redhat dot com]

------- Additional Comments From jan dot kratochvil at redhat dot com  2010-09-29 14:44 -------
fix:
[patch] regression: Quit should not ask with core (PR 12071)
http://sourceware.org/ml/gdb-patches/2010-09/msg00483.html


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=12071

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug corefiles/12071] Regression: just a core file started to ask on quit

[jan dot kratochvil at redhat dot com]

------- Additional Comments From jan dot kratochvil at redhat dot com  2010-09-30 10:25 -------
http://sourceware.org/ml/gdb-cvs/2010-09/msg00181.html

	gdb/
	PR corefiles/12071.
	* inferior.c (have_live_inferiors): New variables old_chain, inf and
	tp.  Iterate INFERIOR_LIST and call target_has_execution.
	
	gdb/testsuite/
	PR corefiles/12071.
	* gdb.base/corefile.exp (quit with a process, no question: load core)
	(quit with a core file): New tests.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=12071

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.