[Bug tui/10723] Dependency on readline internal variable

[Bug tui/10723] Dependency on readline internal variable

[rguenther at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=10723

rguenther at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-07-19
                 CC|                            |rguenther at suse dot de
     Ever Confirmed|0                           |1

--- Comment #1 from rguenther at suse dot de 2012-07-19 12:17:49 UTC ---
Also depends on _rl_print_completions_horizontally and _rl_abort_internal
from tui/tui-io.c

Confirmed.  Please fix.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tui/10723] Dependency on readline internal variable

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10723

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat
                   |                            |dot com

--- Comment #2 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-07-19 12:22:50 UTC ---
Both GDB bundled readline and latest external readline (6.2) provide these
symbols.

So while I understand it is not right from GDB there should not be currently
real usability problems of GDB.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tui/10723] Dependency on readline internal variable

[rguenther at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=10723

--- Comment #3 from rguenther at suse dot de 2012-07-19 12:43:19 UTC ---
Our readline packager had the (great) idea to hide all private symbols which
made gdb link fail for me.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug tui/10723] Dependency on readline internal variable

[Stephane.Carrez at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10723

Bug 10723 depends on bug 10722, which changed state.

Bug 10722 Summary: tui (gdb) prompt empty lines do not newline
http://sourceware.org/bugzilla/show_bug.cgi?id=10722

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/10723] Dependency on readline internal variable

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=10723

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org
          Component|tui                         |build

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Changing component to build, problem is not unique (anymore) to TUI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/10723] Dependency on readline internal variable

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=10723

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #4)
> Changing component to build, problem is not unique (anymore) to TUI.

More specifically:
...
$ find gdb* -type f | egrep -v ChangeLog | xargs egrep -i
"extern.*[^a-zA-Z]_rl_"
gdb/tui/tui-io.c:  extern int _rl_echoing_p;
gdb/completer.c:  extern int _rl_complete_mark_directories;
gdb/completer.c:extern int _rl_completion_prefix_display_length;
gdb/completer.c:extern int _rl_print_completions_horizontally;
gdb/completer.c:EXTERN_C int _rl_qsort_string_compare (const void *, const void
*);
gdb/cli-out.c:EXTERN_C void _rl_erase_entire_line (void);
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/10723] Dependency on readline internal variable

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=10723

--- Comment #6 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=14e61dbbbbb50e2b48834ba489942931514e7ff5

commit 14e61dbbbbb50e2b48834ba489942931514e7ff5
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Dec 16 10:39:17 2023 +0100

    [gdb/build] Remove dependency on _rl_term_autowrap

    Commit deb1ba4e38b ("[gdb/tui] Fix TUI resizing for TERM=ansi") introduced
a
    dependency on readline private variable _rl_term_autowrap.

    There is precedent for this, but it's something we want to get rid of
    (PR build/10723).

    Remove the dependency on _rl_term_autowrap, and instead calculate
    readline_hidden_cols by comparing the environment variable COLS with cols
as
    returned by rl_get_screen_size.

    Tested on x86_64-linux.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=10723

-- 
You are receiving this mail because:
You are on the CC list for the bug.