[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[muhammad_bilal at mentor dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

bilal <muhammad_bilal at mentor dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |muhammad_bilal at mentor
                   |                            |dot com

--- Comment #1 from bilal <muhammad_bilal at mentor dot com> 2012-12-24 08:23:22 UTC ---
Hi Jan

breakpoint on the specific thread Number is hit on source line of file when
specified thread Number is reached .Exit the thread no exit the breakpoint e.g

if you don,t mention the thread number this break point is always hit when this
particular source line reaches 

you can see on this
http://sourceware.org/gdb/onlinedocs/gdb/Thread_002dSpecific-Breakpoints.html



Thanks
Bilal

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[muhammad_bilal at mentor dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

--- Comment #2 from bilal <muhammad_bilal at mentor dot com> 2012-12-24 08:25:05 UTC ---
Hi Jan

breakpoint on the specific thread Number is hit on source line of file when
specified thread Number is reached .Exit the thread no exit the breakpoint e.g

if you don,t mention the thread number this break point is always hit when this
particular source line reaches 

you can see on this
http://sourceware.org/gdb/onlinedocs/gdb/Thread_002dSpecific-Breakpoints.html



Thanks
Bilal

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[waqas.jamil47 at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

Muhammad Waqas <waqas.jamil47 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-07-19
                 CC|                            |waqas.jamil47 at gmail dot com
     Ever confirmed|0                           |1

--- Comment #3 from Muhammad Waqas <waqas.jamil47 at gmail dot com> ---
Jan you are right, breakpoint should be deleted that is related to thread that
does not exist.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[mwaqas at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

Muhammad Waqas <mwaqas at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mwaqas at codesourcery dot com
           Assignee|unassigned at sourceware dot org   |mwaqas at codesourcery dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    palves@sourceware.org    2013-09-17 19:32:47

Modified files:
    gdb            : ChangeLog breakpoint.c 
    gdb/testsuite  : ChangeLog 
Added files:
    gdb/testsuite/gdb.threads: thread-specific-bp.c 
                               thread-specific-bp.exp 

Log message:
    PR gdb/11568 - delete thread-specific breakpoints on thread exit

    PR gdb/11568 is about thread-specific breakpoints being left behind
    when the corresponding thread exits.

    Currently:

    (gdb) b start thread 2
    Breakpoint 3 at 0x400614: file thread-specific-bp.c, line 23.
    (gdb) b end
    Breakpoint 4 at 0x40061f: file thread-specific-bp.c, line 29.
    (gdb) c
    Continuing.
    [Thread 0x7ffff7fcb700 (LWP 14925) exited]
    [Switching to Thread 0x7ffff7fcc740 (LWP 14921)]

    Breakpoint 4, end () at thread-specific-bp.c:29
    29      }
    (gdb) info threads
    Id   Target Id         Frame
    * 1    Thread 0x7ffff7fcc740 (LWP 14921) "thread-specific" end () at
thread-specific-bp.c:29
    (gdb) info breakpoints
    Num     Type           Disp Enb Address            What
    2       breakpoint     keep y   0x0000000000400614 in start at
thread-specific-bp.c:23
    breakpoint already hit 1 time
    3       breakpoint     keep y   0x0000000000400614 in start at
thread-specific-bp.c:23 thread 2
    stop only in thread 2
    4       breakpoint     keep y   0x000000000040061f in end at
thread-specific-bp.c:29
    breakpoint already hit 1 time

    Note that the thread-specific breakpoint 3 stayed around, even though
    thread 2 is gone.

    There's no way that breakpoint can trigger again (*), so the PR argues
    that the breakpoint should just be removed, like local watchpoints.
    I'm ambivalent on this -- it could be reasonable to disable the
    breakpoint (kind of like breakpoint in shared library code when the
    DSO is unloaded), so the user could still use it as visual template
    for creating other breakpoints (copy/paste command lists, etc.), or we
    could have a way to change to which thread a breakpoint applies.  But,
    several people pushed this direction, and I don't plan on arguing...

    (*) - actually, there is ...  thread numbers are reset on "run", so
    the user could do "break foo thread 2", "run", and expect the
    breakpoint to hit again on the second thread.  But given gdb's thread
    numbering can't really be stable, that'd only work sufficiently well
    for thread 1, so we'd better call it unsupported.

    So with the patch, whenever a thread is deleted from GDB's list, GDB
    goes through the thread-specific breakpoints and deletes corresponding
    breakpoints.  Since this is user-visible, GDB prints out:

    Thread-specific breakpoint 3 deleted - thread 2 is gone.

    And of course, we end up with:

    (gdb) info breakpoints
    Num     Type           Disp Enb Address            What
    2       breakpoint     keep y   0x0000000000400614 in start at
thread-specific-bp.c:23
    breakpoint already hit 1 time
    4       breakpoint     keep y   0x000000000040061f in end at
thread-specific-bp.c:29
    breakpoint already hit 1 time

    2013-09-17  Muhammad Waqas <mwaqas@codesourcery.com>
    Pedro Alves  <palves@redhat.com>

    PR gdb/11568
    * breakpoint.c (remove_threaded_breakpoints): New function.
    (_initialize_breakpoint): Attach remove_threaded_breakpoints
    as thread_exit observer.

    2013-09-17  Muhammad Waqas  <mwaqas@codesourccery.com>
    Jan Kratochvil  <jan.kartochvil@redhat.com>
    Pedro Alves  <palves@redhat.com>

    PR gdb/11568
    * gdb.thread/thread-specific-bp.c: New file.
    * gdb.thread/thread-specific-bp.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.16003&r2=1.16004
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/breakpoint.c.diff?cvsroot=src&r1=1.776&r2=1.777
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3810&r2=1.3811
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.threads/thread-specific-bp.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.threads/thread-specific-bp.exp.diff?cvsroot=src&r1=NONE&r2=1.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11568

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |palves at redhat dot com
   Target Milestone|7.1                         |7.7

--- Comment #5 from Pedro Alves <palves at redhat dot com> ---
This is fixed now, but I now remembered I wanted to tweak the docs to mention
thread-specific breakpoints are deleted when the corresponding thread exits. 
Leaving open until that is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11568

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-unknown-linux-gnu    |
               Host|x86_64-unknown-linux-gnu    |
           Assignee|mwaqas at codesourcery dot com     |palves at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    palves@sourceware.org    2013-10-07 11:00:23

Modified files:
    gdb            : ChangeLog breakpoint.c 

Log message:
    Thread-specific breakpoints: say "no longer in the thread list" instead of
"gone".

    It seems "gone" may confuse people, while that was exactly what it was
    trying to avoid.  Switch to saying "no longer in the thread list",
    which is really the predicate GDB uses.

    gdb/
    2013-10-07  Pedro Alves  <palves@redhat.com>

    PR breakpoints/11568
    * breakpoint.c (remove_threaded_breakpoints): Say "no longer in
    the thread list" instead of "gone".

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.16078&r2=1.16079
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/breakpoint.c.diff?cvsroot=src&r1=1.779&r2=1.780

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=11568

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    palves@sourceware.org    2013-10-07 11:13:09

Modified files:
    gdb/doc        : ChangeLog gdb.texinfo 

Log message:
    [DOC] Mention what happens when the thread of a thread-specific breakpoint
disappears.

    We recently made GDB auto-delete thread-specific breakpoints when the
    corresponding thread is removed from the thread list, but we hadn't
    mentioned it in the manual.

    gdb/
    2013-10-07  Pedro Alves  <palves@redhat.com>

    PR breakpoints/11568
    * gdb.texinfo (Thread-Specific Breakpoints): Mention what happens
    when the thread is removed from the thread list.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/ChangeLog.diff?cvsroot=src&r1=1.1494&r2=1.1495
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/gdb.texinfo.diff?cvsroot=src&r1=1.1116&r2=1.1117

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/11568] delete thread-specific breakpoint on the thread exit

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11568

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Pedro Alves <palves at redhat dot com> ---
> This is fixed now, but I now remembered I wanted to tweak the docs to mention 
> thread-specific breakpoints are deleted when the corresponding thread exits.  
> Leaving open until that is done.

Now all done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.