public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/11833] disassemble/m should be PC-driven, not source line driven
Date: Sat, 15 Aug 2015 04:48:00 -0000	[thread overview]
Message-ID: <bug-11833-4717-xtPVfuEruO@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-11833-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=11833

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6ff0ba5f7b8a2b10642bbb233a32043595c55670

commit 6ff0ba5f7b8a2b10642bbb233a32043595c55670
Author: Doug Evans <xdje42@gmail.com>
Date:   Fri Aug 14 21:45:54 2015 -0700

    New /s modifier for the disassemble command.

    The "source centric" /m option to the disassemble command is often
    unhelpful, e.g., in the presence of optimized code.
    This patch adds a /s modifier that is better.
    For one, /m only prints instructions from the originating source file,
    leaving out instructions from e.g., inlined functions from other files.

    gdb/ChangeLog:

        PR gdb/11833
        * NEWS: Document new /s modifier for the disassemble command.
        * cli/cli-cmds.c (disassemble_command): Add support for /s.
        (_initialize_cli_cmds): Update online docs of disassemble command.
        * disasm.c: #include "source.h".
        (struct deprecated_dis_line_entry): Renamed from dis_line_entry.
        All uses updated.
        (dis_line_entry): New struct.
        (hash_dis_line_entry, eq_dis_line_entry): New functions.
        (allocate_dis_line_table): New functions.
        (maybe_add_dis_line_entry, line_has_code_p): New functions.
        (dump_insns): New arg end_pc.  All callers updated.
        (do_mixed_source_and_assembly_deprecated): Renamed from
        do_mixed_source_and_assembly.  All callers updated.
        (do_mixed_source_and_assembly): New function.
        (gdb_disassembly): Handle /s (DISASSEMBLY_SOURCE).
        * disasm.h (DISASSEMBLY_SOURCE_DEPRECATED): Renamed from
        DISASSEMBLY_SOURCE.  All uses updated.
        (DISASSEMBLY_SOURCE): New macro.
        * mi/mi-cmd-disas.c (mi_cmd_disassemble): New modes 4,5.

    gdb/doc/ChangeLog:

        * gdb.texinfo (Machine Code): Update docs for mixed source/assembly
        disassembly.
        (GDB/MI Data Manipulation): Update docs for new disassembly modes.

    gdb/testsuite/ChangeLog:

        * gdb.mi/mi-disassemble.exp: Update.
        * gdb.base/disasm-optim.S: New file.
        * gdb.base/disasm-optim.c: New file.
        * gdb.base/disasm-optim.h: New file.
        * gdb.base/disasm-optim.exp: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-08-15  4:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-11833-4717@http.sourceware.org/bugzilla/>
2011-11-17  2:16 ` dje at google dot com
2012-08-28 21:53 ` jan.smets@alcatel-lucent.com
2015-08-15  4:48 ` cvs-commit at gcc dot gnu.org [this message]
2015-08-15  4:57 ` xdje42 at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-11833-4717-xtPVfuEruO@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).