[Bug python/12119] New: push_frame_filter doesn't close over frame_filter, which will lead to infinite recursion with multiple filters

[Bug python/12119] New: push_frame_filter doesn't close over frame_filter, which will lead to infinite recursion with multiple filters

[markflorisson88 at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12119

           Summary: push_frame_filter doesn't close over frame_filter,
                    which will lead to infinite recursion with multiple
                    filters
           Product: gdb
           Version: archer
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned@sourceware.org
        ReportedBy: markflorisson88@gmail.com


When installing multiple backtrace filters
(gdb/python/lib/gdb/backtrace.py:push_frame_filter), filtering will lead to
infinite recursion because 'frame_filter' is global and not part of the
closure.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/12119] push_frame_filter doesn't close over frame_filter, which will lead to infinite recursion with multiple filters

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12119

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com

--- Comment #1 from Tom Tromey <tromey at redhat dot com> 2011-01-06 21:26:59 UTC ---
Could you try this and verify that it works?

@@ -32,7 +32,7 @@ an iterator returning such objects."""
     if frame_filter == None:
         frame_filter = constructor
     else:
-        frame_filter = lambda iterator: constructor (frame_filter (iterator))
+        frame_filter = lambda iterator, filter = frame_filter: constructor
(filter (iterator))

 def create_frame_filter (iter):
     global frame_filter


Note also that we are going to rewrite this code.
It has some design flaws as-is.
We'll be sure to send a note to the Archer list when this gets underway.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/12119] push_frame_filter doesn't close over frame_filter, which will lead to infinite recursion with multiple filters

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12119

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Tom Tromey <tromey at redhat dot com> 2011-01-07 20:30:53 UTC ---
I checked this in on archer-tromey-python.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.