[Bug symtab/12704] New: physname regression: (anonymous namespace)

[Bug symtab/12704] New: physname regression: (anonymous namespace)

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

           Summary: physname regression: (anonymous namespace)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jan.kratochvil@redhat.com
                CC: keiths@redhat.com
            Target: x86_64-unknown-linux-gnu


namespace FOO { namespace { void BAR() {} } }

pre-physname:
(gdb) b 'FOO::(anonymous namespace)::BAR()' 
Breakpoint 1 at 0x4: file foo2.C, line 1.

post-physname:
(gdb) b 'FOO::(anonymous namespace)::BAR<tab>
FOO::(anonymous namespace)::BAR    FOO::(anonymous namespace)::BAR()  
(gdb) b 'FOO::(anonymous namespace)::BAR()' 
Junk at end of arguments.
(gdb) b FOO::(anonymous namespace)::BAR()
Junk at end of arguments.
(gdb) b 'FOO::(anonymous namespace)::BAR' 
Junk at end of arguments.

there is a regression by the patch (not verified this specific commit has
regressed it but I guess so):
        42284fdf9d8cdb20c8e833bdbdb2b56977fea525
        http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html
        dwarf2_physname patchset:
        [RFA] dwarf2_physname FINAL
        http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2011-05-02 07:27:54 UTC ---
Found by someone on #gdb:
(2011-04-26 06:02:37 CEST) zliu: Hi, all. How to set breakpoint on a symbol in
an "anonymous namespace"?
(2011-04-26 06:06:50 CEST) zliu: e.g. namespace FOO { namespace { func BAR; } }
} How to set breakpoint on FOO::(anonymous namespace)::BAR?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[keiths at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

Keith Seitz <keiths at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at sourceware    |keiths at redhat dot com
                   |dot org                     |

--- Comment #2 from Keith Seitz <keiths at redhat dot com> 2011-05-18 23:56:18 UTC ---
Another linespec bug. Looks like even after this is fixed, c++/12750 may
prevent you from doing anything useful. Grab that patch, too, when it is
available.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2011-05-31 21:54:10 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    kseitz@sourceware.org    2011-05-31 21:54:07

Modified files:
    gdb            : ChangeLog cp-namespace.c cp-support.h 
                     dwarf2read.c linespec.c 

Log message:
    PR symtab/12704
    * cp-namespace.c (ANONYMOUS_NAMESPACE_LEN): Remove.
    (cp_scan_for_anonymous_namespaces): Use CP_ANONYMOUS_NAMESPACE_STR
    and CP_ANONYMOUS_NAMESPACE_LEN.
    (cp_is_anonymous): Likewise.
    * cp-support.h (CP_ANONYMOUS_NAMESPACE_STR): Define.
    (CP_ANONYMOUS_NAMESPACE_LEN): Define.
    * dwarf2read.c (namespace_name): Likewise.
    (fixup_partial_die): Likewise.
    * linespec.c (decode_compound): If CP_ANONYMOUS_NAMESPACE_STR is
    seen in the input, keep it.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.13069&r2=1.13070
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cp-namespace.c.diff?cvsroot=src&r1=1.51&r2=1.52
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cp-support.h.diff?cvsroot=src&r1=1.42&r2=1.43
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&r1=1.539&r2=1.540
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/linespec.c.diff?cvsroot=src&r1=1.120&r2=1.121

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2011-05-31 21:54:51 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    kseitz@sourceware.org    2011-05-31 21:54:49

Modified files:
    gdb/testsuite  : ChangeLog 
Added files:
    gdb/testsuite/gdb.cp: anon-ns.cc anon-ns.exp 

Log message:
    PR symtab/12704
    * gdb.cp/anon-ns.cc: New file.
    * gdb.cp/anon-ns.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.2734&r2=1.2735
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.cp/anon-ns.cc.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.cp/anon-ns.exp.diff?cvsroot=src&r1=NONE&r2=1.1

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[keiths at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

Keith Seitz <keiths at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Keith Seitz <keiths at redhat dot com> 2011-05-31 22:15:38 UTC ---
Patch committed. If there are any further problems, please let me know.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2011-07-02 19:37:25 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Branch:     gdb_7_3-branch
Changes by:    jkratoch@sourceware.org    2011-07-02 19:37:22

Modified files:
    gdb            : ChangeLog cp-namespace.c cp-support.h 
                     dwarf2read.c linespec.c 

Log message:
    commit f658463559c9f03672b0fd226e4941f159e65bc0
    Author: Keith Seitz <keiths@redhat.com>
    Date:   Tue May 31 21:54:06 2011 +0000

    gdb/
    PR symtab/12704
    * cp-namespace.c (ANONYMOUS_NAMESPACE_LEN): Remove.
    (cp_scan_for_anonymous_namespaces): Use CP_ANONYMOUS_NAMESPACE_STR
    and CP_ANONYMOUS_NAMESPACE_LEN.
    (cp_is_anonymous): Likewise.
    * cp-support.h (CP_ANONYMOUS_NAMESPACE_STR): Define.
    (CP_ANONYMOUS_NAMESPACE_LEN): Define.
    * dwarf2read.c (namespace_name): Likewise.
    (fixup_partial_die): Likewise.
    * linespec.c (decode_compound): If CP_ANONYMOUS_NAMESPACE_STR is
    seen in the input, keep it.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.12887.2.46&r2=1.12887.2.47
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cp-namespace.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.49&r2=1.49.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cp-support.h.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.41&r2=1.41.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.518.2.6&r2=1.518.2.7
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/linespec.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.117.2.2&r2=1.117.2.3

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug symtab/12704] physname regression: (anonymous namespace)

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12704

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |7.3

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.