From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id E946A3858D32; Sat, 11 Feb 2023 22:07:38 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E946A3858D32
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1676153258;
	bh=bGLx4cTxs6vbj0j9zfbvdlVhD00ZDWEZRtBSfboneGs=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=bVil/l4v3+6lEDGJ5RYm71NB2cJBgs7rtZv1F4i3mgDYGIvfMkIxoxZ7q36PHiHpK
	 umv4lYS8NqfNQuthMBSlq7fMpDOvjVfDhMumCU7a03yWJfTVxyMXp2PUL8y+/pb3Qo
	 M4XQBoz+fX8t9NhjZY29oBzXiDmr+VkhAdFAvxIA=
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug win32/12716] addresses of exported symbols of a DLL should be
 looked up by ordinal
Date: Sat, 11 Feb 2023 22:07:38 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: win32
X-Bugzilla-Version: 7.2
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mark at klomp dot org
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-12716-4717-GYv3HwLlBq@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-12716-4717@http.sourceware.org/bugzilla/>
References: <bug-12716-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D12716

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
I can confirm that your paperwork is on file.
You submitted the patch and it was reviewed in this thread:
https://inbox.sourceware.org/gdb-patches/1307879815.1831.0.camel@t41.thuisd=
omein/

And it looks like something similar to (or inspired on) your patch was
committed as part of:

commit 3999122f0c8766df3a55462df626d607ebe5a735
Author: Pierre Muller <muller@sourceware.org>
Date:   Thu Dec 13 10:44:45 2012 +0000

            * coff-pe-read.h (pe_text_section_offset): Declare new function.
            * coff-pe-read.c (debug_coff_pe_read): New static variable.
            (struct read_pe_section_data): Add section_name field.
            (IMAGE_SCN_CNT_CODE): New macro, if not already defined.
            (IMAGE_SCN_CNT_INITIALIZED_DATA): Ditto.
            (IMAGE_SCN_CNT_UNINITIALIZED_DATA): Ditto.
            (get_pe_section_index): New function.
            (struct pe_sections_info): New type.
            (get_section_vmas): Use new struct pe_sections_info.
            (add_pe_exported_sym): Handle unnamed exported function.
            (add_pe_forwarded_sym): New function.
            (read_pe_truncate_name): Truncate at last dot.
            (pe_as16): New function.
            (read_pe_exported_syms): Use ordinal of function to
            retrieve correct RVA address of function and handle
            forwarded symbol.
            (pe_text_section_offset): New function.
            (show_debug_coff_pe_read): New function.
            (_initialize_coff_pe_read): New function adding
            'set/show debug coff_pe_read' commands.

            * windows-tdep.c (windows_xfer_shared_library): Use
            pe_text_section_offset function instead of possibly wrong
            0x1000 constant for .text sextion offset.

Which has a very long thread discussing it:
https://inbox.sourceware.org/gdb-patches/006001cdaada$00c81f00$02585d00$@mu=
ller@ics-cnrs.unistra.fr/t/#u

--=20
You are receiving this mail because:
You are on the CC list for the bug.=