[Bug python/13310] New: (cpychecher) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[Bug python/13310] New: (cpychecher) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[dmalcolm at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13310

             Bug #: 13310
           Summary: (cpychecher) Suspected memory leak in
                    gdb/python/py-param.c: call_doc_function()
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned@sourceware.org
        ReportedBy: dmalcolm@redhat.com
    Classification: Unclassified


Created attachment 6012
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6012
HTML report showing the execution paths that leak memory

See attached HTML report from gcc-python-plugin's cpychecker:

  result->ob_refcnt is 1 too high:

It looks to me like the returned "result" object from
PyObject_CallMethodObjArgs() is leaking a reference in each of these paths
through the function.

Caveat: this static analyzer is relatively immature, so it could be getting it
wrong.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13310] (cpychecker) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[dmalcolm at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13310

Dave Malcolm <dmalcolm at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|(cpychecher) Suspected      |(cpychecker) Suspected
                   |memory leak in              |memory leak in
                   |gdb/python/py-param.c:      |gdb/python/py-param.c:
                   |call_doc_function()         |call_doc_function()

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13310] (cpychecker) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[pmuldoon at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13310

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmuldoon at redhat dot com
         AssignedTo|unassigned at sourceware    |pmuldoon at redhat dot com
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13310] (cpychecker) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13310

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2011-10-24 11:39:54 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    pmuldoon@sourceware.org    2011-10-24 11:39:50

Modified files:
    gdb            : ChangeLog 
    gdb/python     : py-param.c 

Log message:
    2011-10-24  Phil Muldoon  <pmuldoon@redhat.com>

    PR python/13310

    * python/py-param.c (call_doc_function): Correctly deference on
    function exit.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.13450&r2=1.13451
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-param.c.diff?cvsroot=src&r1=1.13&r2=1.14

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13310] (cpychecker) Suspected memory leak in gdb/python/py-param.c: call_doc_function()

[pmuldoon at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13310

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |7.4

--- Comment #2 from Phil Muldoon <pmuldoon at redhat dot com> 2011-10-24 11:41:22 UTC ---
Fixed and committed as documented in Comment #1.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.