[Bug python/13331] New: (cpychecker) Segfault in gdb/python/py-function.c:convert_values_to_python under low memory conditions

[Bug python/13331] New: (cpychecker) Segfault in gdb/python/py-function.c:convert_values_to_python under low memory conditions

[dmalcolm at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13331

             Bug #: 13331
           Summary: (cpychecker) Segfault in
                    gdb/python/py-function.c:convert_values_to_python
                    under low memory conditions
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned@sourceware.org
        ReportedBy: dmalcolm@redhat.com
    Classification: Unclassified


Created attachment 6025
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6025
HTML report showing the execution paths that can crash

convert_values_to_python doesn't check the return value from PyTuple_New, which
can return NULL under low memory conditions.

If it returns NULL and argc > 0 then there are two different segfaults
possible; see attached HTML.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13331] (cpychecker) Segfault in gdb/python/py-function.c:convert_values_to_python under low memory conditions

[pmuldoon at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13331

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmuldoon at redhat dot com
         AssignedTo|unassigned at sourceware    |pmuldoon at redhat dot com
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13331] (cpychecker) Segfault in gdb/python/py-function.c:convert_values_to_python under low memory conditions

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13331

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2011-10-27 10:30:02 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    pmuldoon@sourceware.org    2011-10-27 10:29:58

Modified files:
    gdb            : ChangeLog 
    gdb/python     : py-function.c 

Log message:
    2011-10-27  Phil Muldoon  <pmuldoon@redhat.com>

    PR python/13331

    * python/py-function.c (fnpy_call): Check 'args' is not NULL.
    (convert_values_to_python): Return on Python tuple allocation
    failure.  Return NULL on value conversion error.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.13464&r2=1.13465
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-function.c.diff?cvsroot=src&r1=1.10&r2=1.11

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/13331] (cpychecker) Segfault in gdb/python/py-function.c:convert_values_to_python under low memory conditions

[pmuldoon at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13331

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |7.4

--- Comment #2 from Phil Muldoon <pmuldoon at redhat dot com> 2011-10-27 10:31:52 UTC ---
Fixed and committed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.