From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-10782-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 23559 invoked by alias); 2 Nov 2011 15:12:02 -0000
Received: (qmail 23530 invoked by uid 22791); 2 Nov 2011 15:12:00 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0
	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 15:11:47 +0000
From: "tromey at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/13374] New: bad GIL uses
Date: Wed, 02 Nov 2011 15:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: python
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-13374-4717@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
X-SW-Source: 2011-q4/txt/msg00193.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=13374

             Bug #: 13374
           Summary: bad GIL uses
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned@sourceware.org
        ReportedBy: tromey@redhat.com
    Classification: Unclassified


While reading the code I found a couple of spots where
the GIL is treated weirdly.

I don't see why gdbpy_decode_line should acquire the GIL.
This function will only be called in a Python context.

Acquiring the GIL in inferior_to_inferior object seems weird.
It isn't necessarily incorrect but it seems like it would be
preferable to acquire this in whichever callers need it;
usually these X_to_X_object calls are expected to be used in
a Python context.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.