From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 013953858C42; Sun, 31 Dec 2023 13:08:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 013953858C42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704028120; bh=INaQaUa6KFPveHPQUDZl4+tMizly51/vmabCwYvxdcY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=N3cPcxhbVX+I9IhfFd9KFTmxvnXZGhhtWNJpVBHik6ZNCFThs/dmOaEAzTyS9FjZv PtfU9/6yw3T2cfqqE7DzwzqCPFfQ9yEMRLbSiSj8irxco7/Zg58E0nj8kzXDxD4bDc n1k1SsUFX1w7B4oP3BwR5YJr7yG8zXRo4KLVxXjs= From: "ssbssa at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug gdb/13498] save-index makes gdb slow with dwarf4 Date: Sun, 31 Dec 2023 13:08:39 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: ssbssa at sourceware dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dje at google dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D13498 Hannes Domani changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssbssa at sourceware dot o= rg --- Comment #12 from Hannes Domani --- (In reply to Sourceware Commits from comment #11) > CVSROOT: /cvs/src > Module name: src > Changes by: devans@sourceware.org 2012-07-10 20:28:34 >=20 > Modified files: > gdb : ChangeLog dwarf2read.c=20 >=20 > Log message: > PR gdb/13498 > * dwarf2read.c (dwarf2_per_objfile): New members n_type_unit_groups, > all_type_unit_groups, type_unit_groups, tu_stats. > (dwarf2_per_cu_data): Move "imported_symtabs" into new union "s". > All uses updated. Add type_unit_group to union "s". > (type_unit_group): New struct. > (IS_TYPE_UNIT_GROUP): New macro. > (abbrev_table): Delete unused member "section". > (dw2_do_instantiate_symtab): Early exit if type_unit_group. > (dw2_get_cu): Assert not used with type_unit_group. > (dw2_get_primary_cu): New function. > (dw2_build_type_unit_groups_reader): New function. > (dw2_build_type_unit_groups): New function. > (dw2_get_file_names): Assert not called on type units. > (dw2_map_symtabs_matching_filename): Call dw2_build_type_unit_groups. > Redo loop to iterate over type unit groups instead of type units. > (dw2_expand_symtabs_matching, dw2_map_symbol_filenames): Ditto. > (read_abbrev_offset): New function. > (init_cutu_and_read_dies): New arg "abbrev_table". All callers > updated. > (create_partial_symtab): New function. > (process_psymtab_comp_unit_reader): Assert not used with type units. > Call create_partial_symtab. > (process_psymtab_type_unit): Delete. > (hash_type_unit_group, eq_type_unit_group): New functions. > (allocate_type_unit_groups_table): New function. > (NO_STMT_LIST_TYPE_UNIT_PSYMTAB): New macro. > (NO_STMT_LIST_TYPE_UNIT_PSYMTAB_SIZE): New macro. > (create_type_unit_group, get_type_unit_group): New functions. > (tu_abbrev_offset): New struct. > (sort_tu_by_abbrev_offset): New function. > (add_type_unit_group_to_table): New function. > (build_type_unit_groups): New function. > (build_type_psymtabs_reader): New function. > (build_type_psymtab_dependencies): New function. > (build_type_psymtabs): Rewrite. > (scan_partial_symbols): Flag an error if a DW_TAG_imported_unit > is seen in a type unit. > (process_queue): Move symtab expansion debugging printfs here. > Call process_full_type_unit for type units. > (compute_symtab_includes): Assert not called for type units. > (process_cu_includes): Don't call compute_symtab_includes for > type units. > (process_full_type_unit): New function. > (process_imported_unit_die): Flag an error if called for type units. > (handle_DW_AT_stmt_list): Delete arg "want_line_info". All callers > updated. Assert not called for type units. > (read_file_scope): Call dwarf2_start_symtab. > (setup_type_unit_groups): New function. > (read_type_unit_scope): Rewrite. > (abbrev_table_read_table): Initialize abbrev_table->offset. > (abbrev_table_free_cleanup): New function. > (dwarf2_start_symtab): New function. > (load_full_type_unit): Assert not called for type unit groups. >=20 > Patches: > http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog. > diff?cvsroot=3Dsrc&r1=3D1.14457&r2=3D1.14458 > http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c. > diff?cvsroot=3Dsrc&r1=3D1.683&r2=3D1.684 Did this coommit fix the issue, and can it be closed? --=20 You are receiving this mail because: You are on the CC list for the bug.=