public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "l.lunak at suse dot cz" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/13498] save-index makes gdb slow with dwarf4
Date: Wed, 14 Dec 2011 23:28:00 -0000	[thread overview]
Message-ID: <bug-13498-4717-s7ZgjiA7qv@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13498-4717@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=13498

--- Comment #1 from Luboš Luňák <l.lunak at suse dot cz> 2011-12-14 23:27:48 UTC ---
Ok, I think I've figured out where the problem is.

When completing, location_completer() calls also
make_source_files_completion_list(), which calls
map_partial_symbol_filenames(). That one is where most of the time during the
completion is spent - it calls the proper map_symbol_filenames function
depending on the debugging format - for .so's without an index, it's
map_symbol_filenames_psymtab(), for indexed files, it is
dw2_map_symbol_filenames().

The problem is, with dwarf4-based index, dw2_map_symbol_filenames() iterates
over a huge number of filenames, magnitudes more than with dwarf2-based index
or psymtabs (in my case, it's 35M filenames with dwarf4 index, 380k with dwarf4
without index, 720k with dwarf2 index, 220k with dwarf2 without index). All the
time is spent just iterating over them. And the number is so high because there
are many duplicates, as high as 175k duplicates for the most common header
files.

I don't know DWARF or gdb, so I'm not sure what the proper fix should be.
Possibly the save-index functionality should try to eliminate these duplicates.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  reply	other threads:[~2011-12-14 23:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 17:21 [Bug gdb/13498] New: " l.lunak at suse dot cz
2011-12-14 23:28 ` l.lunak at suse dot cz [this message]
2011-12-15 15:55 ` [Bug gdb/13498] " l.lunak at suse dot cz
2012-02-15 12:12 ` lionel at mamane dot lu
2012-02-16 11:00 ` mjw at redhat dot com
2012-02-17 21:48 ` tromey at redhat dot com
2012-02-17 21:52 ` tromey at redhat dot com
2012-02-20 13:51 ` l.lunak at suse dot cz
2012-02-20 19:51 ` tromey at redhat dot com
2012-02-20 19:55 ` tromey at redhat dot com
2012-02-20 20:57 ` cvs-commit at gcc dot gnu.org
2012-02-21  6:32 ` dje at google dot com
2012-02-21 18:17 ` l.lunak at suse dot cz
2012-07-08 19:35 ` dje at google dot com
2012-07-10 20:29 ` cvs-commit at gcc dot gnu.org
2023-12-31 13:08 ` ssbssa at sourceware dot org
2023-12-31 16:42 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13498-4717-s7ZgjiA7qv@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).