[Bug exp/13907] New: RFE: Resolve static pointers in pretty printer

[Bug exp/13907] New: RFE: Resolve static pointers in pretty printer

[avi at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13907

             Bug #: 13907
           Summary: RFE: Resolve static pointers in pretty printer
           Product: gdb
           Version: 7.3
            Status: NEW
          Severity: normal
          Priority: P2
         Component: exp
        AssignedTo: unassigned@sourceware.org
        ReportedBy: avi@redhat.com
    Classification: Unclassified


When gdb prints out a function pointer, it looks it up in the symbol table and
prints the function name:

  $5 = {read = 0x55555567f85f <pic_ioport_read>, ...

However, it doesn't do the same for data pointers:

  $3 = {ops = 0x555555b6ba60, ...
  (gdb) p &pic_base_ioport_ops 
  $6 = (const MemoryRegionOps *) 0x555555b6ba60

It would be nice if $3 read as

  $3 = {ops = 0x555555b6ba60 <&pic_base_ioport_ops>, ...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug exp/13907] RFE: Resolve static pointers in pretty printer

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13907

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com
         AssignedTo|unassigned at sourceware    |tromey at redhat dot com
                   |dot org                     |

--- Comment #1 from Tom Tromey <tromey at redhat dot com> 2012-03-30 14:48:54 UTC ---
Testing a patch.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug exp/13907] RFE: Resolve static pointers in pretty printer

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13907

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-05-18 15:31:48 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    tromey@sourceware.org    2012-05-18 15:31:42

Modified files:
    gdb            : ChangeLog NEWS c-valprint.c defs.h f-valprint.c 
                     p-valprint.c printcmd.c valprint.c valprint.h 
                     value.h 
    gdb/doc        : ChangeLog gdb.texinfo 
    gdb/testsuite  : ChangeLog 
    gdb/testsuite/gdb.ada: fun_addr.exp 
    gdb/testsuite/gdb.base: call-ar-st.exp call-strs.exp find.exp 
                            funcargs.exp pointers.exp printcmds.exp 
    gdb/testsuite/gdb.cp: casts.exp classes.exp virtbase.exp 
    gdb/testsuite/gdb.mi: mi-var-cmd.exp 
    gdb/testsuite/gdb.objc: basicclass.exp 

Log message:
    PR exp/13907:
    * valprint.h (struct value_print_options) <symbol_print>: New
    field.
    * valprint.c (user_print_options): Add default for symbol_print.
    (show_symbol_print): New function.
    (generic_val_print): Respect symbol_print.
    (_initialize_valprint): Add "print symbol" setting.
    * f-valprint.c (f_val_print): Respect symbol_print.
    * c-valprint.c (c_val_print): Respect symbol_print.
    * NEWS: Update.
    * printcmd.c (print_address_symbolic): Return int.  Ignore some
    zero-size symbols.
    (print_address_demangle): Return int.
    * defs.h: (print_address_symbolic): Return int.
    * value.h (print_address_demangle): Return int.
    doc
    * gdb.texinfo (Print Settings): Document 'set print symbol'.
    testsuite
    * gdb.mi/mi-var-cmd.exp: Update.
    * gdb.objc/basicclass.exp (do_objc_tests): Update.
    * gdb.cp/virtbase.exp: Update.
    * gdb.cp/classes.exp (test_static_members): Update.
    * gdb.cp/casts.exp: Update.
    * gdb.base/pointers.exp: Update.
    * gdb.base/funcargs.exp (pointer_args): Update.
    (structs_by_reference): Update.
    * gdb.base/find.exp: Update.
    * gdb.base/call-strs.exp: Send "set print symbol off".
    * gdb.base/call-ar-st.exp: Update.
    * gdb.ada/fun_addr.exp: Update.
    * gdb.base/printcmds.exp (test_print_symbol): New proc.
    Call it.
    (test_print_repeats_10, test_print_strings)
    (test_print_char_arrays): Update.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14265&r2=1.14266
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/NEWS.diff?cvsroot=src&r1=1.520&r2=1.521
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/c-valprint.c.diff?cvsroot=src&r1=1.96&r2=1.97
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/defs.h.diff?cvsroot=src&r1=1.314&r2=1.315
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/f-valprint.c.diff?cvsroot=src&r1=1.74&r2=1.75
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/p-valprint.c.diff?cvsroot=src&r1=1.98&r2=1.99
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/printcmd.c.diff?cvsroot=src&r1=1.206&r2=1.207
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/valprint.c.diff?cvsroot=src&r1=1.125&r2=1.126
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/valprint.h.diff?cvsroot=src&r1=1.41&r2=1.42
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/value.h.diff?cvsroot=src&r1=1.204&r2=1.205
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/ChangeLog.diff?cvsroot=src&r1=1.1318&r2=1.1319
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/gdb.texinfo.diff?cvsroot=src&r1=1.964&r2=1.965
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3198&r2=1.3199
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/fun_addr.exp.diff?cvsroot=src&r1=1.8&r2=1.9
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/call-ar-st.exp.diff?cvsroot=src&r1=1.32&r2=1.33
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/call-strs.exp.diff?cvsroot=src&r1=1.19&r2=1.20
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/find.exp.diff?cvsroot=src&r1=1.10&r2=1.11
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/funcargs.exp.diff?cvsroot=src&r1=1.27&r2=1.28
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/pointers.exp.diff?cvsroot=src&r1=1.26&r2=1.27
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/printcmds.exp.diff?cvsroot=src&r1=1.43&r2=1.44
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.cp/casts.exp.diff?cvsroot=src&r1=1.15&r2=1.16
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.cp/classes.exp.diff?cvsroot=src&r1=1.32&r2=1.33
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.cp/virtbase.exp.diff?cvsroot=src&r1=1.9&r2=1.10
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.mi/mi-var-cmd.exp.diff?cvsroot=src&r1=1.50&r2=1.51
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.objc/basicclass.exp.diff?cvsroot=src&r1=1.16&r2=1.17

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug exp/13907] RFE: Resolve static pointers in pretty printer

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13907

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |7.5

--- Comment #3 from Tom Tromey <tromey at redhat dot com> 2012-05-18 15:32:43 UTC ---
Sorry about the delay on this.
The fix is in now.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.