* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
@ 2012-08-15 14:55 ` tromey at redhat dot com
2012-08-15 15:15 ` tromey at redhat dot com
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-15 14:55 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
Tom Tromey <tromey at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at redhat dot com
AssignedTo|unassigned at sourceware |tromey at redhat dot com
|dot org |
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
2012-08-15 14:55 ` [Bug gdb/14119] " tromey at redhat dot com
@ 2012-08-15 15:15 ` tromey at redhat dot com
2012-08-15 16:00 ` tromey at redhat dot com
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-15 15:15 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #1 from Tom Tromey <tromey at redhat dot com> 2012-08-15 15:14:38 UTC ---
Worked in 7.3, fails in 7.4+
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
2012-08-15 14:55 ` [Bug gdb/14119] " tromey at redhat dot com
2012-08-15 15:15 ` tromey at redhat dot com
@ 2012-08-15 16:00 ` tromey at redhat dot com
2012-08-15 16:02 ` jan.kratochvil at redhat dot com
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-15 16:00 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #2 from Tom Tromey <tromey at redhat dot com> 2012-08-15 15:59:28 UTC ---
The fundamental issue here is that frame_id_inlined_p
and skip_inline_frames disagree about whether a tailcall
frame is "inlined".
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (2 preceding siblings ...)
2012-08-15 16:00 ` tromey at redhat dot com
@ 2012-08-15 16:02 ` jan.kratochvil at redhat dot com
2012-08-15 17:23 ` tromey at redhat dot com
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jan.kratochvil at redhat dot com @ 2012-08-15 16:02 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
Jan Kratochvil <jan.kratochvil at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jan.kratochvil at redhat
| |dot com
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (3 preceding siblings ...)
2012-08-15 16:02 ` jan.kratochvil at redhat dot com
@ 2012-08-15 17:23 ` tromey at redhat dot com
2012-08-15 19:49 ` jan.kratochvil at redhat dot com
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-15 17:23 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #3 from Tom Tromey <tromey at redhat dot com> 2012-08-15 17:22:23 UTC ---
Created attachment 6579
--> http://sourceware.org/bugzilla/attachment.cgi?id=6579
patch for testing
I'm testing this patch.
It works on the original test case.
I'm not really convinced this is correct, though.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (4 preceding siblings ...)
2012-08-15 17:23 ` tromey at redhat dot com
@ 2012-08-15 19:49 ` jan.kratochvil at redhat dot com
2012-08-16 17:48 ` tromey at redhat dot com
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jan.kratochvil at redhat dot com @ 2012-08-15 19:49 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #4 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-08-15 19:48:59 UTC ---
I believe 'finish' should step out of inlined frames one frame at a time.
The same like 'step' steps in one frame at a time, also without changing PC.
The same should apply to tailcall frames (just step-in is irrelevant for them).
In general GDB should behave for -O2 -g inferior as much the same as to the
same inferior built with -O0 -g.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (5 preceding siblings ...)
2012-08-15 19:49 ` jan.kratochvil at redhat dot com
@ 2012-08-16 17:48 ` tromey at redhat dot com
2012-08-16 19:00 ` tromey at redhat dot com
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-16 17:48 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #5 from Tom Tromey <tromey at redhat dot com> 2012-08-16 17:47:22 UTC ---
(In reply to comment #4)
> I believe 'finish' should step out of inlined frames one frame at a time.
> The same like 'step' steps in one frame at a time, also without changing PC.
> The same should apply to tailcall frames (just step-in is irrelevant for them).
I wouldn't mind it, but I don't plan to do it myself.
I think perhaps the fix here ought to just ignore tailcall frames
rather than both tail- and inlined- frames.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (6 preceding siblings ...)
2012-08-16 17:48 ` tromey at redhat dot com
@ 2012-08-16 19:00 ` tromey at redhat dot com
2012-09-12 18:04 ` jan.kratochvil at redhat dot com
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tromey at redhat dot com @ 2012-08-16 19:00 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
Tom Tromey <tromey at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|tromey at redhat dot com |unassigned at sourceware
| |dot org
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (7 preceding siblings ...)
2012-08-16 19:00 ` tromey at redhat dot com
@ 2012-09-12 18:04 ` jan.kratochvil at redhat dot com
2012-09-17 7:16 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jan.kratochvil at redhat dot com @ 2012-09-12 18:04 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
Jan Kratochvil <jan.kratochvil at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned at sourceware |jan.kratochvil at redhat
|dot org |dot com
--- Comment #6 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-09-12 18:04:12 UTC ---
[patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)
http://sourceware.org/ml/gdb-patches/2012-09/msg00218.html
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (8 preceding siblings ...)
2012-09-12 18:04 ` jan.kratochvil at redhat dot com
@ 2012-09-17 7:16 ` cvs-commit at gcc dot gnu.org
2012-09-17 7:18 ` cvs-commit at gcc dot gnu.org
2012-09-17 7:22 ` jan.kratochvil at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2012-09-17 7:16 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-09-17 07:15:56 UTC ---
CVSROOT: /cvs/src
Module name: src
Changes by: jkratoch@sourceware.org 2012-09-17 07:15:48
Modified files:
gdb : ChangeLog frame.c infcmd.c
gdb/testsuite : ChangeLog
Added files:
gdb/testsuite/gdb.arch: amd64-tailcall-ret.S
amd64-tailcall-ret.c
amd64-tailcall-ret.exp
gdb/testsuite/gdb.reverse: amd64-tailcall-reverse.S
amd64-tailcall-reverse.c
amd64-tailcall-reverse.exp
Log message:
gdb/
PR 14119
* frame.c (skip_inlined_frames): Skip also TAILCALL_FRAME frames.
(frame_pop): Drop also TAILCALL_FRAME frames.
* infcmd.c (finish_command): Ignore also TAILCALL_FRAME frames.
gdb/testsuite/
PR 14119
* gdb.arch/amd64-tailcall-ret.S: New file.
* gdb.arch/amd64-tailcall-ret.c: New file.
* gdb.arch/amd64-tailcall-ret.exp: New file.
* gdb.reverse/amd64-tailcall-reverse.S: New file.
* gdb.reverse/amd64-tailcall-reverse.c: New file.
* gdb.reverse/amd64-tailcall-reverse.exp: New file.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14663&r2=1.14664
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/frame.c.diff?cvsroot=src&r1=1.309&r2=1.310
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/infcmd.c.diff?cvsroot=src&r1=1.312&r2=1.313
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3375&r2=1.3376
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.S.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.S.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp.diff?cvsroot=src&r1=NONE&r2=1.1
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (9 preceding siblings ...)
2012-09-17 7:16 ` cvs-commit at gcc dot gnu.org
@ 2012-09-17 7:18 ` cvs-commit at gcc dot gnu.org
2012-09-17 7:22 ` jan.kratochvil at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2012-09-17 7:18 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-09-17 07:17:35 UTC ---
CVSROOT: /cvs/src
Module name: src
Branch: gdb_7_5-branch
Changes by: jkratoch@sourceware.org 2012-09-17 07:17:28
Modified files:
gdb : ChangeLog frame.c infcmd.c
gdb/testsuite : ChangeLog
Added files:
gdb/testsuite/gdb.arch: amd64-tailcall-ret.S
amd64-tailcall-ret.c
amd64-tailcall-ret.exp
gdb/testsuite/gdb.reverse: amd64-tailcall-reverse.S
amd64-tailcall-reverse.c
amd64-tailcall-reverse.exp
Log message:
gdb/
PR 14119
* frame.c (skip_inlined_frames): Skip also TAILCALL_FRAME frames.
(frame_pop): Drop also TAILCALL_FRAME frames.
* infcmd.c (finish_command): Ignore also TAILCALL_FRAME frames.
gdb/testsuite/
PR 14119
* gdb.arch/amd64-tailcall-ret.S: New file.
* gdb.arch/amd64-tailcall-ret.c: New file.
* gdb.arch/amd64-tailcall-ret.exp: New file.
* gdb.reverse/amd64-tailcall-reverse.S: New file.
* gdb.reverse/amd64-tailcall-reverse.c: New file.
* gdb.reverse/amd64-tailcall-reverse.exp: New file.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.14469.2.32&r2=1.14469.2.33
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/frame.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.306&r2=1.306.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/infcmd.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.306&r2=1.306.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.3295.2.22&r2=1.3295.2.23
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.S.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.arch/amd64-tailcall-ret.exp.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.S.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.reverse/amd64-tailcall-reverse.exp.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=NONE&r2=1.1.2.1
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug gdb/14119] F17: failed assertion `!frame_id_inlined_p (frame_id)'
2012-05-16 18:13 [Bug gdb/14119] New: F17: failed assertion `!frame_id_inlined_p (frame_id)' jim at meyering dot net
` (10 preceding siblings ...)
2012-09-17 7:18 ` cvs-commit at gcc dot gnu.org
@ 2012-09-17 7:22 ` jan.kratochvil at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: jan.kratochvil at redhat dot com @ 2012-09-17 7:22 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14119
Jan Kratochvil <jan.kratochvil at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |7.5
--- Comment #9 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-09-17 07:21:45 UTC ---
Checked in for 7.5.1.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread