public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug cli/14321] New: find can clobber memory
@ 2012-07-01 18:52 jan.kratochvil at redhat dot com
2012-07-01 19:42 ` [Bug cli/14321] find may " jan.kratochvil at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: jan.kratochvil at redhat dot com @ 2012-07-01 18:52 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=14321
Bug #: 14321
Summary: find can clobber memory
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: cli
AssignedTo: unassigned@sourceware.org
ReportedBy: jan.kratochvil@redhat.com
Classification: Unclassified
GNU gdb (GDB) 7.4.50.20120630-cvs
./gdb ./gdb
(gdb) find main,+100000000,xop_table
memory clobbered past end of allocated block
This code does not expect val_bytes can be huge:
findcmd.c:
/* Keep it simple and assume size == 'g' when watching for when we
need to grow the pattern buf. */
if ((pattern_buf_end - pattern_buf + max (val_bytes, sizeof (int64_t)))
> pattern_buf_size)
{
size_t current_offset = pattern_buf_end - pattern_buf;
pattern_buf_size *= 2;
pattern_buf = xrealloc (pattern_buf, pattern_buf_size);
pattern_buf_end = pattern_buf + current_offset;
}
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug cli/14321] find may clobber memory 2012-07-01 18:52 [Bug cli/14321] New: find can clobber memory jan.kratochvil at redhat dot com @ 2012-07-01 19:42 ` jan.kratochvil at redhat dot com 2012-07-06 15:52 ` cvs-commit at gcc dot gnu.org 2012-07-06 15:55 ` jan.kratochvil at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: jan.kratochvil at redhat dot com @ 2012-07-01 19:42 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=14321 Jan Kratochvil <jan.kratochvil at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|find can clobber memory |find may clobber memory -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug cli/14321] find may clobber memory 2012-07-01 18:52 [Bug cli/14321] New: find can clobber memory jan.kratochvil at redhat dot com 2012-07-01 19:42 ` [Bug cli/14321] find may " jan.kratochvil at redhat dot com @ 2012-07-06 15:52 ` cvs-commit at gcc dot gnu.org 2012-07-06 15:55 ` jan.kratochvil at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2012-07-06 15:52 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=14321 --- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-07-06 15:51:43 UTC --- CVSROOT: /cvs/src Module name: src Changes by: jkratoch@sourceware.org 2012-07-06 15:51:40 Modified files: gdb : ChangeLog findcmd.c gdb/testsuite : ChangeLog gdb/testsuite/gdb.base: find.exp Log message: gdb/ PR 14321 * findcmd.c (parse_find_args): New variable pattern_buf_size_need. Increase buffer sizes to 2x we need, not just 2x of the previous size. gdb/testsuite/ PR 14321 * gdb.base/find.exp (find int64_search_buf, +64/8*100, int64_search_buf): New test. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14443&r2=1.14444 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/findcmd.c.diff?cvsroot=src&r1=1.18&r2=1.19 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3278&r2=1.3279 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/find.exp.diff?cvsroot=src&r1=1.11&r2=1.12 -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug cli/14321] find may clobber memory 2012-07-01 18:52 [Bug cli/14321] New: find can clobber memory jan.kratochvil at redhat dot com 2012-07-01 19:42 ` [Bug cli/14321] find may " jan.kratochvil at redhat dot com 2012-07-06 15:52 ` cvs-commit at gcc dot gnu.org @ 2012-07-06 15:55 ` jan.kratochvil at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: jan.kratochvil at redhat dot com @ 2012-07-06 15:55 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=14321 Jan Kratochvil <jan.kratochvil at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2012-07-06 15:54:38 UTC --- Checked in. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-06 15:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-07-01 18:52 [Bug cli/14321] New: find can clobber memory jan.kratochvil at redhat dot com 2012-07-01 19:42 ` [Bug cli/14321] find may " jan.kratochvil at redhat dot com 2012-07-06 15:52 ` cvs-commit at gcc dot gnu.org 2012-07-06 15:55 ` jan.kratochvil at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).