[Bug python/14387] New: Memory leak in gdb/python/py-stopevent.c:66

[Bug python/14387] New: Memory leak in gdb/python/py-stopevent.c:66

[m at bruenink dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14387

             Bug #: 14387
           Summary: Memory leak in gdb/python/py-stopevent.c:66
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
        AssignedTo: unassigned@sourceware.org
        ReportedBy: m@bruenink.de
    Classification: Unclassified


In py-stopevent.c:66 a PyList is created which is than attached to a stop event
by calling create_breakpoint_event_object. This list is never garbage
collected.

Decrementing the reference count to the list after line 83 fixed the problem
for me.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/14387] Memory leak in gdb/python/py-stopevent.c:66

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14387

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at redhat dot com

--- Comment #1 from Tom Tromey <tromey at redhat dot com> 2012-08-01 16:59:45 UTC ---
Not only that, but pretty much every call to PyObject_SetAttrString
in gdb seems to be wrong.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/14387] Memory leak in gdb/python/py-stopevent.c:66

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14387

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sourceware    |tromey at redhat dot com
                   |dot org                     |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/14387] Memory leak in gdb/python/py-stopevent.c:66

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14387

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2012-08-15 14:22:10 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    tromey@sourceware.org    2012-08-15 14:22:02

Modified files:
    gdb            : ChangeLog 
    gdb/python     : py-bpevent.c py-event.c py-exitedevent.c 
                     py-newobjfileevent.c py-signalevent.c 
                     py-stopevent.c py-threadevent.c py-type.c 

Log message:
    PR python/14387:
    * python/py-bpevent.c (create_breakpoint_event_object): Update
    comment.
    * python/py-event.c (evpy_add_attribute): Update comment.
    * python/py-exitedevent.c (create_exited_event_object): Fix
    reference counting and error handling.
    * python/py-newobjfileevent.c (create_new_objfile_event_object):
    Fix reference counting.
    * python/py-signalevent.c (create_signal_event_object): Fix
    reference counting and error handling.
    * python/py-stopevent.c (emit_stop_event): Fix reference
    counting.
    * python/py-threadevent.c (get_event_thread): Return a
    borrowed reference.
    * python/py-type.c (convert_field): Fix reference counting.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14588&r2=1.14589
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-bpevent.c.diff?cvsroot=src&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-event.c.diff?cvsroot=src&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-exitedevent.c.diff?cvsroot=src&r1=1.4&r2=1.5
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-newobjfileevent.c.diff?cvsroot=src&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-signalevent.c.diff?cvsroot=src&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-stopevent.c.diff?cvsroot=src&r1=1.5&r2=1.6
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-threadevent.c.diff?cvsroot=src&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/python/py-type.c.diff?cvsroot=src&r1=1.41&r2=1.42

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug python/14387] Memory leak in gdb/python/py-stopevent.c:66

[tromey at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14387

Tom Tromey <tromey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |7.6

--- Comment #3 from Tom Tromey <tromey at redhat dot com> 2012-08-15 14:27:52 UTC ---
Fixed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.