public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "palves at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/14531] gdb.base/dprintf.exp fails in newlib environment
Date: Mon, 10 Sep 2012 13:27:00 -0000	[thread overview]
Message-ID: <bug-14531-4717-50pJSTv1dj@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14531-4717@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=14531

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palves at redhat dot com

--- Comment #2 from Pedro Alves <palves at redhat dot com> 2012-09-10 13:27:13 UTC ---
How about adding a function like 

 FILE *get_stderr () { return stderr; }

to the test's .c file, and do 

  set dprintf-function fprintf
  set dprintf-channel get_stderr()

instead of 

  set dprintf-function fprintf
  set dprintf-channel stderr

IOW, avoid the need of macro debug info for all targets.

AFAICS, the code does:

  else if (strcmp (dprintf_style, dprintf_style_call) == 0)
    {
      if (!dprintf_function)
        error (_("No function supplied for dprintf call"));

      if (dprintf_channel && strlen (dprintf_channel) > 0)
        printf_line = xstrprintf ("call (void) %s (%s,%s)",
                                  dprintf_function,
                                  dprintf_channel,
                                  dprintf_args);
      else
        printf_line = xstrprintf ("call (void) %s (%s)",
                                  dprintf_function,
                                  dprintf_args);
    }

So that'll expand to one infcall to

  fprintf (get_stderr (), ...)

instead of:

  fprintf (stderr, ...)

Which is the same thing -- still one infcall.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2012-09-10 13:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 17:31 [Bug testsuite/14531] New: " yufeng.zhang at arm dot com
2012-09-08 14:39 ` [Bug testsuite/14531] " qiyao at gcc dot gnu.org
2012-09-10 13:27 ` palves at redhat dot com [this message]
2012-09-18  9:49 ` yufeng.zhang at arm dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-14531-4717-50pJSTv1dj@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).