public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "dblaikie at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug c++/14998] GDB cannot handle pointer to member functions being encoded with DW_TAG_ptr_to_member_type
Date: Mon, 07 Jan 2013 19:11:00 -0000	[thread overview]
Message-ID: <bug-14998-4717-qfONCCmwwM@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14998-4717@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=14998

--- Comment #7 from David Blaikie <dblaikie at gmail dot com> 2013-01-07 19:11:41 UTC ---
> I was expecting the subroutine type to have an artificial parameter
> for the "this" pointer.

Your reading of the DWARF is correct. Clang currently doesn't emit the 'this'
parameter. The DWARF standard is a bit vague on this:

"The pointer to member entry has a DW_AT_type attribute to describe the type of
the class or structure member to which objects of this type may point."

but it seems like if the DW_AT_type of a pointer-to-member variable "int
foo::*x;" is simply "int", then the DW_AT_type of a pointer-to-member function
"int (foo::*x)(float)" would be "int(float)".

> I think if that was added then calling would work.

Curious - I could try this, though it's a little non-trivial to construct that
artificial type in Clang.

If it works, though, then I'd consider this bug to be lower priority but still
'nice to have' (essentially GDB would detect whether the first parameter is
artificial (& the same type as the DW_AT_containing_type) & if so, use that,
otherwise insert such a parameter based on the DW_AT_containing_type if that's
the representation it prefers).

What are your thoughts on this?

> Printing the artificial argument appears to be a conscious decision.
> From c-typeprint.c:
> 
> Artificial arguments, such as "this"
>    in non-static methods, are displayed if LINKAGE_NAME is zero
> 
> I think this is a bit weird though.  

I guess LINKAGE_NAME is DW_AT_MIPS_linkage_name? Though in any case a function
pointer won't have a known/fixed name for the function, so I guess it's always
'zero'/always displayed?

> I wouldn't mind changing it or perhaps adding a ptype flag to control it.

Would there be a need to? It's implied by the containing_type mentioned within
the name:

int (foo::*)(float)
     ^^^

Mentioning it again in the parameter list seems redundant. (though I guess some
tools might've come to rely on this which might be a justification for keeping
it in some form?)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2013-01-07 19:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07  1:10 [Bug c++/14998] New: " dblaikie at gmail dot com
2013-01-07 15:41 ` [Bug c++/14998] " tromey at redhat dot com
2013-01-07 17:11 ` tromey at redhat dot com
2013-01-07 17:57 ` dblaikie at gmail dot com
2013-01-07 17:58 ` dblaikie at gmail dot com
2013-01-07 17:59 ` dblaikie at gmail dot com
2013-01-07 19:01 ` tromey at redhat dot com
2013-01-07 19:11 ` dblaikie at gmail dot com [this message]
2013-01-07 19:35 ` tromey at redhat dot com
2013-01-07 19:41 ` dblaikie at gmail dot com
2013-01-08  3:08 ` dblaikie at gmail dot com
2013-01-08  4:48 ` tromey at redhat dot com
2013-01-08 17:12 ` tromey at redhat dot com
2013-01-19 19:22 ` dblaikie at gmail dot com
2013-01-31 17:41 ` cvs-commit at gcc dot gnu.org
2013-01-31 17:42 ` tromey at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-14998-4717-qfONCCmwwM@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).