public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/15161] symfile.c:struct load_section_data::load_offset is "unsigned long" but should be wider.
Date: Tue, 19 Feb 2013 20:53:00 -0000	[thread overview]
Message-ID: <bug-15161-4717-LK0MvdVfC9@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15161-4717@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=15161

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-02-19 20:53:04 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    palves@sourceware.org    2013-02-19 20:52:58

Modified files:
    gdb/gdbserver  : ChangeLog server.c 

Log message:
    gdbserver:server.c - use unpack_varlen_hex to extract hex numbers.

    Addresses, as most numbers in the RSP are hex encoded, with variable
    length (that just means the width isn't specified, and there's no top
    cap.  So they should be extracted with unpack_varlen_hex.

    A couple spots in server.c are using strto(u)l, which doesn't work on
    LLP64 targets.

    This patch fixes it.

    Tested on x86_64 Fedora 17.

    2013-02-19  Pedro Alves  <palves@redhat.com>
    Kai Tietz <ktietz@redhat.com>

    PR gdb/15161

    * server.c (handle_query) <CRC check>: Use unpack_varlen_hex
    instead of strtoul to extract address from packet.
    (process_serial_event) <'z'>: Likewise.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.681&r2=1.682
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.c.diff?cvsroot=src&r1=1.184&r2=1.185

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2013-02-19 20:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 15:22 [Bug gdb/15161] New: " palves at redhat dot com
2013-02-19 16:19 ` [Bug gdb/15161] " palves at redhat dot com
2013-02-19 18:32 ` cvs-commit at gcc dot gnu.org
2013-02-19 19:27 ` cvs-commit at gcc dot gnu.org
2013-02-19 20:53 ` cvs-commit at gcc dot gnu.org [this message]
2013-02-19 20:57 ` palves at redhat dot com
2013-02-19 20:59 ` palves at redhat dot com
2013-02-19 21:11 ` palves at redhat dot com
2013-02-19 21:20 ` palves at redhat dot com
2013-02-19 21:21 ` palves at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15161-4717-LK0MvdVfC9@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).