From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23055 invoked by alias); 19 Feb 2013 20:53:06 -0000 Received: (qmail 23020 invoked by uid 55); 19 Feb 2013 20:53:05 -0000 From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug gdb/15161] symfile.c:struct load_section_data::load_offset is "unsigned long" but should be wider. Date: Tue, 19 Feb 2013 20:53:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org X-SW-Source: 2013-q1/txt/msg00261.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=15161 --- Comment #4 from cvs-commit at gcc dot gnu.org 2013-02-19 20:53:04 UTC --- CVSROOT: /cvs/src Module name: src Changes by: palves@sourceware.org 2013-02-19 20:52:58 Modified files: gdb/gdbserver : ChangeLog server.c Log message: gdbserver:server.c - use unpack_varlen_hex to extract hex numbers. Addresses, as most numbers in the RSP are hex encoded, with variable length (that just means the width isn't specified, and there's no top cap. So they should be extracted with unpack_varlen_hex. A couple spots in server.c are using strto(u)l, which doesn't work on LLP64 targets. This patch fixes it. Tested on x86_64 Fedora 17. 2013-02-19 Pedro Alves Kai Tietz PR gdb/15161 * server.c (handle_query) : Use unpack_varlen_hex instead of strtoul to extract address from packet. (process_serial_event) <'z'>: Likewise. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.681&r2=1.682 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/server.c.diff?cvsroot=src&r1=1.184&r2=1.185 -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.